You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/01 20:48:11 UTC
Re: Review Request 45537: Updated testing `Environment` to remove
temp dirs after each test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45537/#review126629
-----------------------------------------------------------
Fix it, then Ship it!
Verified the patch fix the tests teardown issue in a test suite, by testing on small-size disk VMs with some out-of-disk fix commits reverted.
src/tests/environment.cpp (line 728)
<https://reviews.apache.org/r/45537/#comment189639>
Should we use `listeners.Append(Owned<TemporaryDirectoryEventListener>(temporaryDirectoryEventListener));` here?
- Gilbert Song
On March 31, 2016, 5:17 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45537/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 5:17 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-5044
> https://issues.apache.org/jira/browse/MESOS-5044
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated testing `Environment` to remove temp dirs after each test.
>
>
> Diffs
> -----
>
> src/tests/environment.hpp 9932f7c530dee3180bbbdf6c06e1e0ec424b46b9
> src/tests/environment.cpp 7617e43587cb81104786d06f753f08565a6c2d0a
>
> Diff: https://reviews.apache.org/r/45537/diff/
>
>
> Testing
> -------
>
> Verified that make check doesn't leak any temporary directories.
> The exception seems to be some mesos-XXXXX directories created by example frameworks.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>