[jira] [Commented] (IMPALA-9975) Introduce new admission control daemon

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263835#comment-17263835 ] 

ASF subversion and git services commented on IMPALA-9975:
---------------------------------------------------------

Commit aa48651cb5a0ca035326c0cf1356889703422f20 in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=aa48651 ]

IMPALA-9975 (part 1): Various refactors for admission control daemon

This patch contains a variety of small refactors needed to enable the
new admission control daemon, to separate them out from the main patch
for ease of reviewing.

The following changes are made:
- A new class is introduced, DaemonEnv, which contains singleton
  objects common to all Impala daemons, currently just a MetricGroup
  and Webservers. The purpose is to reduce code duplication when the
  new admissiond daemon is added. This is analogous to how ExecEnv is
  used for impalad-specific singletons already.

  This patch modifies the catalogd and statestored to use DaemonEnv.
  impalads could also use DaemonEnv, but its tricky due to
  dependencies in the order of creation and initialization for objects
  such as the ReservationTracker and BufferPool relative to the
  MetricGroup and Webserver, so this is left for followup work.

- Direct use of ExecEnv in ImpalaServicePool ahd AdmissionController
  is removed, as the admissiond will also need to use these classes
  and it will not have an ExecEnv.

Testing:
- Passed a run of existing core tests.

Change-Id: I2e097e20458354f78bfc3477cac6fb3a2835f094
Reviewed-on: http://gerrit.cloudera.org:8080/16890
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Introduce new admission control daemon
> --------------------------------------
>
>                 Key: IMPALA-9975
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9975
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Distributed Exec
>    Affects Versions: Impala 4.0
>            Reporter: Thomas Tauber-Marshall
>            Assignee: Thomas Tauber-Marshall
>            Priority: Major
>
> To facilitate the new single admission control service, we should separate out the admission controller to run in its own separate daemon.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org