You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/18 10:54:14 UTC

[GitHub] [flink] pnowojski commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

pnowojski commented on pull request #17440:
URL: https://github.com/apache/flink/pull/17440#issuecomment-945645624


   Most likely we added `notifyNewBufferSize` to the `ChannelHandler` to follow the same path as `notifyCreditAvailable`. At least me myself, have not given much thought whether it should actually be implemented how you are proposing. Maybe you are right @dawidwys . 
   
   I don't know why `notifyCreditAvailable` was added the way it was added. Maybe that was also a wrong place to add it.
   
   I haven't read the full thread, so I'm not sure. If we had changed the way you are proposing @dawidwys , would it solve/help solve the problems in this ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org