You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zjhmale (GitHub)" <gi...@apache.org> on 2020/02/24 12:30:57 UTC
[GitHub] [dubbo-go] zjhmale opened pull request #373: fix(apollo/ut):
ignore apollo property file which generated by ut
Even base on `develop` branch, the temp JSON file is still on the fly after the ut process finished
```
On branch develop
Untracked files:
(use "git add <file>..." to include in what will be committed)
config_center/apollo/mockDubbog.properties.json
nothing added to commit but untracked files present (use "git add" to track)
```
One possible reason is that the [100ms](https://github.com/apache/dubbo-go/blob/master/config_center/apollo/impl_test.go#L271) is not long enough to wait until the JSON file creation process done from another goroutine.
[ Full content available at: https://github.com/apache/dubbo-go/pull/373 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #373:
fix(apollo/ut): ignore apollo property file which generated by ut
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
@zouyx pls check it and merge it.
[ Full content available at: https://github.com/apache/dubbo-go/pull/373 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #373:
fix(apollo/ut): ignore apollo property file which generated by ut
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/373?src=pr&el=h1) Report
> Merging [#373](https://codecov.io/gh/apache/dubbo-go/pull/373?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/67ccfb23bfa27ac1ee178a2a704467b15316ac47?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #373 +/- ##
===========================================
- Coverage 66.78% 66.72% -0.07%
===========================================
Files 150 150
Lines 7963 7963
===========================================
- Hits 5318 5313 -5
- Misses 2142 2146 +4
- Partials 503 504 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/373/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `64.7% <0%> (-8.83%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/373/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/373?src=pr&el=footer). Last update [67ccfb2...c7868ea](https://codecov.io/gh/apache/dubbo-go/pull/373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/373 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx closed pull request #373: fix(apollo/ut):
ignore apollo property file which generated by ut
Posted by "zouyx (GitHub)" <gi...@apache.org>.
[ pull request closed by zouyx ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/373 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org