You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by robertwb <gi...@git.apache.org> on 2017/05/25 23:20:56 UTC

[GitHub] beam pull request #3228: [BEAM-2366] Don't try to pickle gen_protos in tests...

GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/3228

    [BEAM-2366] Don't try to pickle gen_protos in tests.

    Tests that pickle the main session but are run from setup.py attempt
    to pickle everything visible in setup.py.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam BEAM-2366

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3228
    
----
commit 3b7eae4040eba65e8a6167eb802849273eca588b
Author: Robert Bradshaw <ro...@gmail.com>
Date:   2017-05-25T23:17:54Z

    [BEAM-2366] Don't try to pickle gen_protos in tests.
    
    Tests that pickle the main session but are run from setup.py attempt
    to pickle everything visible in setup.py.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3228: [BEAM-2366] Don't try to pickle gen_protos in tests...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3228


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---