Re: JDK 17 Support Proposal for ant generate-idea-files in CASSANDRA-18467

[Ekaterina Dimitrova <e....@gmail.com>]

Dear all,

Thanks to everyone who shared feedback and tested the changes. The patch
was committed.

‘ant generate-idea-files’ now support JDK8, JDK11, and JDK17
To add support for another JDK the java-jvmargs property must be set for
the JDK in question (see how it’s done in build.xml for Java 11 and 17)
Other minor, but notable changes are:
- test jvmargs are now added to idea run configuration
-.idea dir and project iml file are first removed and then recreated during
‘ant generate-idea-files’

Best regards,
Ekaterina

On Mon, 15 May 2023 at 5:18, Jakub Zytka <ja...@datastax.com> wrote:

> Dear Team,
>
> I am writing to discuss a proposal I've made in CASSANDRA-18467, which
> pertains to offering JDK 17 support for the ant generate-idea-files
> command. With this support in place, when you run ant generate-idea-files
> using Java 17, the resulting IntelliJ IDEA project will have the necessary
> settings to build and run tests with Java 17 within the IDE. This is
> similar to how the current Java 11 support works.
>
> In addition to this primary enhancement, I have also made two other minor,
> but significant updates:
>
>    1. The .idea subdirectory and the project IML files are now removed
>    when running ant generate-idea-files. However, please note that these
>    files are still unaffected when you run ant realclean.
>    2. The JUnit run configurations now include additional test JVM
>    arguments, referred to as _std-test-jvmargs in build.xml.
>
> Given the nature of these changes, I have conducted manual tests on the
> IntelliJ projects created. I validated these changes in two distinct
> environments:
>
>    1. Separate repositories for different JDKs, with no JDK switching
>    within a single repository.
>    2. A single repository with JDK switching.
>
> If your workflow differs from these scenarios, I kindly request you to
> test these changes and share your feedback. Alternatively, please inform me
> about your unique workflow, and I will conduct the necessary testing on my
> end.
>
> The updated code can be accessed at the following GitHub link:
> https://github.com/jakubzytka/cassandra/tree/CASSANDRA-18467
>
> You can also view the pull request here:
> https://github.com/apache/cassandra/pull/2320
>
> I look forward to hearing your thoughts on this proposal.
>
> Best regards, Kuba
>