You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/07/28 10:29:11 UTC

[GitHub] [kylin] langdamao commented on issue #768: KYLIN-4106 fix Illegal partition for SelfDefineSortableKey

langdamao commented on issue #768: KYLIN-4106 fix Illegal partition for SelfDefineSortableKey 
URL: https://github.com/apache/kylin/pull/768#issuecomment-515751085
 
 
   > Hello Damao, please combine the two commits into one commit, and only keep the necessary code change in it. You can make that by re-fork the latest master branch, make the code change, and then raise the PR.
   > 
   > BTW, the commit message should start with the JIRA ID, no "[]" needed. Thank you for making Kylin better!
   
   Thank you so much. 
   I think I've done this in a little "violence" way . I delete my fork repository, and fork again. Also I delete my branch and repush it. For the result, this pr lost it's banded branch :(, sorry for this. 
   I've create another pr for this same issue : https://github.com/apache/kylin/pull/777  
   May I ask is there any good way to re-fork the latest master branch？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services