You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/11 17:04:18 UTC
[GitHub] [airflow] potiuk opened a new pull request #11420: Using new version of setup-kind using new add-path mechanism
potiuk opened a new pull request #11420:
URL: https://github.com/apache/airflow/pull/11420
Add Path was deprecated in
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
and will be removed soon, so this PR changes the mechanism to
the new one.
The path is added to the ${GITHUB_PATH} file instead as described in
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#adding-a-system-path
For now this was (hopefully) fixed in potiuk's fork but the
plan is to make PR to the original action and use it from
there once it is merged.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11420: Using new version of setup-kind using new add-path mechanism
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11420:
URL: https://github.com/apache/airflow/pull/11420#discussion_r502954439
##########
File path: .github/workflows/ci.yml
##########
@@ -660,7 +660,7 @@ jobs:
- name: "Free space"
run: ./scripts/ci/tools/ci_free_space_on_ci.sh
- name: "Setup Kind Cluster ${{ env.KIND_VERSION }}"
- uses: engineerd/setup-kind@v0.4.0
+ uses: potiuk/setup-kind@7345a7e015d9844bab5f4a8a8cfb4eb3cf7f91ef
Review comment:
Not yet. But I plan to do it when I get it working (for now I opened the issue https://github.com/engineerd/setup-kind/issues/28). For now, it seems that the way they implemented it, we cannot even link to the commit hash for security (seems that you can only link to packaged .zip uploaded as a package which is not really what you want).
I added generated .js code back to the repo (it was .gitignored) but it's not enough - their npm run pack does not create a fully working and minified .js. I had no time to investigate but either I will make it "properly" and PR back (and they hopefully approve) or we find another action for it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11420: Using new version of setup-kind using new add-path mechanism
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11420:
URL: https://github.com/apache/airflow/pull/11420#discussion_r502960893
##########
File path: .github/workflows/ci.yml
##########
@@ -660,7 +660,7 @@ jobs:
- name: "Free space"
run: ./scripts/ci/tools/ci_free_space_on_ci.sh
- name: "Setup Kind Cluster ${{ env.KIND_VERSION }}"
- uses: engineerd/setup-kind@v0.4.0
+ uses: potiuk/setup-kind@7345a7e015d9844bab5f4a8a8cfb4eb3cf7f91ef
Review comment:
Oh ugh :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11420: Using new version of setup-kind using new add-path mechanism
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11420:
URL: https://github.com/apache/airflow/pull/11420#issuecomment-706743762
Seems it needs more work :(. The setup-kind action is not well prepared for serving directly from the repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11420: Using new version of setup-kind using new add-path mechanism
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11420:
URL: https://github.com/apache/airflow/pull/11420#discussion_r502949402
##########
File path: .github/workflows/ci.yml
##########
@@ -660,7 +660,7 @@ jobs:
- name: "Free space"
run: ./scripts/ci/tools/ci_free_space_on_ci.sh
- name: "Setup Kind Cluster ${{ env.KIND_VERSION }}"
- uses: engineerd/setup-kind@v0.4.0
+ uses: potiuk/setup-kind@7345a7e015d9844bab5f4a8a8cfb4eb3cf7f91ef
Review comment:
Did you pr this upstream? If so could you add a comment to the yaml saying "change back when X is merged"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #11420: Using new version of setup-kind using new add-path mechanism
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #11420:
URL: https://github.com/apache/airflow/pull/11420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11420: Using new version of setup-kind using new add-path mechanism
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11420:
URL: https://github.com/apache/airflow/pull/11420#issuecomment-706754501
Converted it to Draft for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11420: Using new version of setup-kind using new add-path mechanism
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11420:
URL: https://github.com/apache/airflow/pull/11420#issuecomment-706743799
Possibly we should even change the action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org