Re: [PR] DRILL-8393: Allow parameters to be passed to headers through SQL in WHERE clause (drill)

["LYCJeff (via GitHub)" <gi...@apache.org>]

LYCJeff commented on PR #2747:
URL: https://github.com/apache/drill/pull/2747#issuecomment-1449446242

   > @LYCJeff I really like the functionality here, but I am concerned that this is a breaking change and will affect existing Drill users. Also, it adds effectively new syntax to the SQL queries.
   
   @cgivre At this point, I can pass the unprefixed parameters in their place by default, the way they were. This minimizes the impact on existing users, except in the following cases. For example, the argument that the user passed into the request body was called `header.xxx`, but now needs to be rewritten as `body.header.xxx`, otherwise the argument will be passed into the request header.
   
   In addition, a problem that had been fixed would reappear. The argument that is passed to the url path is also passed to the end of the url, which has been clearly distinguished since I changed it.
   
   Let me know if you think this is more friendly to existing users, then I'll move in this direction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org