[GitHub] [solr] noblepaul commented on a diff in pull request #1655: SOLR-16812: Support CBOR format for update/query

["noblepaul (via GitHub)" <gi...@apache.org>]

noblepaul commented on code in PR #1655:
URL: https://github.com/apache/solr/pull/1655#discussion_r1206117294


##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/GenericSolrRequest.java:
##########
@@ -42,6 +44,22 @@ public GenericSolrRequest setContentWriter(ContentWriter contentWriter) {
     return this;
   }
 
+  public GenericSolrRequest withContent(byte[] buf, String type) {

Review Comment:
   I don't think so.
   Users can already do so with their own `ContentWriter` impl. This is just a helper method
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org