You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Bruno Matos (JIRA)" <qp...@incubator.apache.org> on 2010/04/21 15:33:50 UTC

[jira] Created: (QPID-2527) Remove Thread::id() dependency

Remove Thread::id() dependency
------------------------------

                 Key: QPID-2527
                 URL: https://issues.apache.org/jira/browse/QPID-2527
             Project: Qpid
          Issue Type: Task
          Components: C++ Client
    Affects Versions: 0.7
         Environment: Mac OS X
            Reporter: Bruno Matos


The first stop in client compilation on Mac OS X is the return value of Thread::id(). It seams that this method should be removed, so lets start from removing the dependencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2527) Remove Thread::id() dependency

Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859396#action_12859396 ] 

Andrew Stitcher commented on QPID-2527:
---------------------------------------

There are 2 major uses of Thread::id():

1. For use in the logging subsystem to indicate the thread a message has come from (encapsulated in logId()). This could use some other way to indicate the thread - perhaps a sequential thread number starting at 0 - This would make the numbers easier to read too.

2. To compare Thread identity - it seems to me that this would be better achieved by writing a Thread::operator= (which could use pthread_t under the covers if necessary).

> Remove Thread::id() dependency
> ------------------------------
>
>                 Key: QPID-2527
>                 URL: https://issues.apache.org/jira/browse/QPID-2527
>             Project: Qpid
>          Issue Type: Task
>          Components: C++ Client
>    Affects Versions: 0.7
>         Environment: Mac OS X
>            Reporter: Bruno Matos
>
> The first stop in client compilation on Mac OS X is the return value of Thread::id(). It seams that this method should be removed, so lets start from removing the dependencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-2527) Remove Thread::id() dependency

Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Stitcher resolved QPID-2527.
-----------------------------------

    Fix Version/s: 0.7
       Resolution: Fixed

This issue should now be fixed - although there is improvement possible to Thread::logId()

> Remove Thread::id() dependency
> ------------------------------
>
>                 Key: QPID-2527
>                 URL: https://issues.apache.org/jira/browse/QPID-2527
>             Project: Qpid
>          Issue Type: Task
>          Components: C++ Client
>    Affects Versions: 0.7
>         Environment: Mac OS X
>            Reporter: Bruno Matos
>             Fix For: 0.7
>
>
> The first stop in client compilation on Mac OS X is the return value of Thread::id(). It seams that this method should be removed, so lets start from removing the dependencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Issue Comment Edited: (QPID-2527) Remove Thread::id() dependency

Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859396#action_12859396 ] 

Andrew Stitcher edited comment on QPID-2527 at 4/21/10 12:05 PM:
-----------------------------------------------------------------

There are 2 major uses of Thread::id():

1. For use in the logging subsystem to indicate the thread a message has come from (encapsulated in logId()). This could use some other way to indicate the thread - perhaps a sequential thread number starting at 0 - This would make the numbers easier to read too.

2. To compare Thread identity - it seems to me that this would be better achieved by writing a Thread::operator== (which could use pthread_t under the covers if necessary).

      was (Author: astitcher):
    There are 2 major uses of Thread::id():

1. For use in the logging subsystem to indicate the thread a message has come from (encapsulated in logId()). This could use some other way to indicate the thread - perhaps a sequential thread number starting at 0 - This would make the numbers easier to read too.

2. To compare Thread identity - it seems to me that this would be better achieved by writing a Thread::operator= (which could use pthread_t under the covers if necessary).
  
> Remove Thread::id() dependency
> ------------------------------
>
>                 Key: QPID-2527
>                 URL: https://issues.apache.org/jira/browse/QPID-2527
>             Project: Qpid
>          Issue Type: Task
>          Components: C++ Client
>    Affects Versions: 0.7
>         Environment: Mac OS X
>            Reporter: Bruno Matos
>
> The first stop in client compilation on Mac OS X is the return value of Thread::id(). It seams that this method should be removed, so lets start from removing the dependencies.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org