You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/10/21 08:45:07 UTC
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
948193394@qq.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16618
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
[tool] fix inconsistent definition among tool_action_common header and src
Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
---
M src/kudu/tools/tool_action_common.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/1
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <94...@qq.com>
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16618 )
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16618/1/src/kudu/tools/tool_action_common.h
File src/kudu/tools/tool_action_common.h:
http://gerrit.cloudera.org:8080/#/c/16618/1/src/kudu/tools/tool_action_common.h@109
PS1, Line 109: // Retrieve flags from a remote server.
: //
: // If 'address' does not contain a port, 'default_port' is used instead.
: //
: // 'all_flags' controls whether all flags are returned, or only flags which are
: // explicitly set.
: //
: // 'flags_to_get' specify one or more flags to return, sperated by comma.
: //
: // 'flag_tags' is a comma-separated list of tags used to restrict which flags
: // are returned. An empty value matches all tags.
: Status GetServerFlags(const std::string& address,
: uint16_t default_port,
: bool all_flags,
: const std::string& flags_to_get,
: const std::string& flag_tags,
: std::vector<server::GetFlagsResponsePB_Flag>* flags) WARN_UNUSED_RESULT;
It seems this function isn't used anywhere else but tool_action_common.cc. I think a better approach would be just making this function local to tool_action_common.cc (i.e. put it into a anonymous namespace along with GetClusterName()), moving the documentation of the signature there as well.
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <94...@qq.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Oct 2020 17:23:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16618
to look at the new patch set (#4).
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
[tool] fix inconsistent definition among tool_action_common header and src
Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
2 files changed, 38 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/4
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <li...@126.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16618 )
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
[tool] fix inconsistent definition among tool_action_common header and src
Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Reviewed-on: http://gerrit.cloudera.org:8080/16618
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
2 files changed, 38 insertions(+), 45 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <li...@126.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16618
to look at the new patch set (#3).
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
[tool] fix inconsistent definition among tool_action_common header and src
Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
2 files changed, 40 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/3
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@126.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16618 )
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
Patch Set 6: Code-Review+2
Looks good to me.
Thank you for your contribution!
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@126.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 Oct 2020 15:23:40 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16618
to look at the new patch set (#2).
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
[tool] fix inconsistent definition among tool_action_common header and src
Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
2 files changed, 32 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/2
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@126.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16618
to look at the new patch set (#6).
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
[tool] fix inconsistent definition among tool_action_common header and src
Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
2 files changed, 38 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/6
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <li...@126.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] fix inconsistent definition among tool action common header and src
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16618
to look at the new patch set (#5).
Change subject: [tool] fix inconsistent definition among tool_action_common header and src
......................................................................
[tool] fix inconsistent definition among tool_action_common header and src
Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
2 files changed, 38 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/16618/5
--
To view, visit http://gerrit.cloudera.org:8080/16618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81fe9799be01608c0984d6266c5a1163cfe41ada
Gerrit-Change-Number: 16618
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <li...@126.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)