You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Joel Clark (JIRA)" <ji...@apache.org> on 2010/02/23 19:18:27 UTC
[jira] Created: (COUCHDB-669) Minor code cleanup in
couch_httpd_auth
Minor code cleanup in couch_httpd_auth
--------------------------------------
Key: COUCHDB-669
URL: https://issues.apache.org/jira/browse/COUCHDB-669
Project: CouchDB
Issue Type: Improvement
Reporter: Joel Clark
Priority: Trivial
While experimenting with a custom handler I found some code repeated several times. Figured I'd get my feet wet with both Couch and Erlang at the same time and submit a patch that removes the repetition. Please review and apply as you see fit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-669) Minor code cleanup in
couch_httpd_auth
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837374#action_12837374 ]
Jan Lehnardt commented on COUCHDB-669:
--------------------------------------
Hi Joel,
this is a good patch, you're doing it right :)
Only a few comments:
Line 39 of the patch adds a new empty line with one indenting level of spaces. It is customary to keep separate patches for code changes and whitespace changes, since code changes are hard to spot when you only change whitespace in a line. Now your whitespace is in an isolated place so it is hardly a big deal, but it can make larger patches hard to read. No biggie :)
Secondly, we try to avoid trailing whitespace, so if you want to add a new empty line (which is fine), try not having extra spaces in there.
In concise form, these are summed up in our coding guidelines: http://wiki.apache.org/couchdb/Coding_Standards
Other than that the patch is looking good, thanks! :)
> Minor code cleanup in couch_httpd_auth
> --------------------------------------
>
> Key: COUCHDB-669
> URL: https://issues.apache.org/jira/browse/COUCHDB-669
> Project: CouchDB
> Issue Type: Improvement
> Reporter: Joel Clark
> Priority: Trivial
> Attachments: COUCH-669.diff
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> While experimenting with a custom handler I found some code repeated several times. Figured I'd get my feet wet with both Couch and Erlang at the same time and submit a patch that removes the repetition. Please review and apply as you see fit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-669) Minor code cleanup in
couch_httpd_auth
Posted by "Joel Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Clark updated COUCHDB-669:
-------------------------------
Attachment: (was: COUCH-669.diff)
> Minor code cleanup in couch_httpd_auth
> --------------------------------------
>
> Key: COUCHDB-669
> URL: https://issues.apache.org/jira/browse/COUCHDB-669
> Project: CouchDB
> Issue Type: Improvement
> Reporter: Joel Clark
> Priority: Trivial
> Attachments: COUCH-669.diff
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> While experimenting with a custom handler I found some code repeated several times. Figured I'd get my feet wet with both Couch and Erlang at the same time and submit a patch that removes the repetition. Please review and apply as you see fit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-669) Minor code cleanup in
couch_httpd_auth
Posted by "Joel Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Clark updated COUCHDB-669:
-------------------------------
Attachment: COUCH-669.diff
Re-attached patch, removed unneeded get_user/1 overload.
> Minor code cleanup in couch_httpd_auth
> --------------------------------------
>
> Key: COUCHDB-669
> URL: https://issues.apache.org/jira/browse/COUCHDB-669
> Project: CouchDB
> Issue Type: Improvement
> Reporter: Joel Clark
> Priority: Trivial
> Attachments: COUCH-669.diff
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> While experimenting with a custom handler I found some code repeated several times. Figured I'd get my feet wet with both Couch and Erlang at the same time and submit a patch that removes the repetition. Please review and apply as you see fit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-669) Minor code cleanup in
couch_httpd_auth
Posted by "Joel Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Clark updated COUCHDB-669:
-------------------------------
Attachment: COUCH-669.diff
I've never submitted a patch to an open source project before, so please let me know if I did not do it correctly.
> Minor code cleanup in couch_httpd_auth
> --------------------------------------
>
> Key: COUCHDB-669
> URL: https://issues.apache.org/jira/browse/COUCHDB-669
> Project: CouchDB
> Issue Type: Improvement
> Reporter: Joel Clark
> Priority: Trivial
> Attachments: COUCH-669.diff
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> While experimenting with a custom handler I found some code repeated several times. Figured I'd get my feet wet with both Couch and Erlang at the same time and submit a patch that removes the repetition. Please review and apply as you see fit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (COUCHDB-669) Minor code cleanup in
couch_httpd_auth
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis resolved COUCHDB-669.
---------------------------------------
Resolution: Fixed
Assignee: Paul Joseph Davis
Applied as of r915476.
> Minor code cleanup in couch_httpd_auth
> --------------------------------------
>
> Key: COUCHDB-669
> URL: https://issues.apache.org/jira/browse/COUCHDB-669
> Project: CouchDB
> Issue Type: Improvement
> Reporter: Joel Clark
> Assignee: Paul Joseph Davis
> Priority: Trivial
> Attachments: COUCH-669.diff
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> While experimenting with a custom handler I found some code repeated several times. Figured I'd get my feet wet with both Couch and Erlang at the same time and submit a patch that removes the repetition. Please review and apply as you see fit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.