You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bobu-putheeckal (via GitHub)" <gi...@apache.org> on 2026/05/24 13:58:15 UTC
[PR] Improve airflowctl required field validation [airflow]
bobu-putheeckal opened a new pull request, #67410:
URL: https://github.com/apache/airflow/pull/67410
Improve airflowctl client-side validation for API request bodies so missing required generated Pydantic fields are reported clearly before building/sending requests.
Changes:
- Add a reusable required-field validator using Pydantic field `is_required()`.
- Validate generated request body models before dumping them for API requests.
- Reuse the validator while importing pools, variables, and connections from JSON so missing API-required fields point to the specific missing input.
- Add focused tests for direct API operations and import commands.
Closes: #57721
Tests:
- `uv run --project airflow-ctl ruff check airflow-ctl/src/airflowctl/api/operations.py airflow-ctl/src/airflowctl/ctl/cli_config.py airflow-ctl/src/airflowctl/ctl/commands/connection_command.py airflow-ctl/src/airflowctl/ctl/commands/pool_command.py airflow-ctl/src/airflowctl/ctl/commands/variable_command.py airflow-ctl/src/airflowctl/exceptions.py airflow-ctl/tests/airflow_ctl/api/test_operations.py airflow-ctl/tests/airflow_ctl/ctl/commands/test_connections_command.py airflow-ctl/tests/airflow_ctl/ctl/commands/test_pool_command.py airflow-ctl/tests/airflow_ctl/ctl/commands/test_variable_command.py`
- `uv run --project airflow-ctl pytest airflow-ctl/tests`
---
##### Was generative AI tooling used to co-author this PR?
- [x] Yes (OpenAI Codex)
Generated-by: OpenAI Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve airflowctl required field validation [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #67410:
URL: https://github.com/apache/airflow/pull/67410#issuecomment-4529403018
@bobu-putheeckal A few things need addressing before review — see our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
- :x: **Static checks fail**: `CI image checks / Static checks`. See the [Checks tab](https://github.com/apache/airflow/pull/67410/checks).
No rush.
---
_Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._
---
Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve airflowctl required field validation [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil closed pull request #67410: Improve airflowctl required field validation
URL: https://github.com/apache/airflow/pull/67410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve airflowctl required field validation [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #67410:
URL: https://github.com/apache/airflow/pull/67410#issuecomment-4529872059
PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve airflowctl required field validation [airflow]
Posted by "bobu-putheeckal (via GitHub)" <gi...@apache.org>.
bobu-putheeckal commented on PR #67410:
URL: https://github.com/apache/airflow/pull/67410#issuecomment-4529799694
Pushed `6bf4de8d6e` to address the `ruff format` static-check failure. The current PR check rollup no longer shows `CI image checks / Static checks` failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org