You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by al...@apache.org on 2017/07/11 08:57:29 UTC
[2/6] cordova-plugin-splashscreen git commit: CB-11488 (browser) The
hide() call became non re-entrant after the addition of fade out. This fixes
the issue.
CB-11488 (browser) The hide() call became non re-entrant after the addition of fade out. This fixes the issue.
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/commit/a18cc824
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/tree/a18cc824
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/diff/a18cc824
Branch: refs/heads/master
Commit: a18cc8241ae040ef622e0732b91e44fda072efab
Parents: bf9607e
Author: Peter (Somogyvari) Metz <pe...@unarin.com>
Authored: Sun Jun 26 21:10:50 2016 +0100
Committer: Alexander Sorokin <al...@akvelon.com>
Committed: Tue Jul 11 10:55:18 2017 +0300
----------------------------------------------------------------------
src/browser/SplashScreenProxy.js | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/blob/a18cc824/src/browser/SplashScreenProxy.js
----------------------------------------------------------------------
diff --git a/src/browser/SplashScreenProxy.js b/src/browser/SplashScreenProxy.js
index cd3b7fd..83c37d5 100644
--- a/src/browser/SplashScreenProxy.js
+++ b/src/browser/SplashScreenProxy.js
@@ -81,17 +81,19 @@ var SplashScreen = {
},
hide: function () {
if(localSplash) {
+ var innerLocalSplash = localSplash;
+ localSplash = null;
window.removeEventListener("resize", onResize, false);
- localSplash.style.opacity = '0';
- localSplash.style["-webkit-transition"] = "opacity 1s ease-in-out";
- localSplash.style["-moz-transition"] = "opacity 1s ease-in-out";
- localSplash.style["-ms-transition"] = "opacity 1s ease-in-out";
- localSplash.style["-o-transition"] = "opacity 1s ease-in-out";
+ innerLocalSplash.style.opacity = '0';
+ innerLocalSplash.style["-webkit-transition"] = "opacity 1s ease-in-out";
+ innerLocalSplash.style["-moz-transition"] = "opacity 1s ease-in-out";
+ innerLocalSplash.style["-ms-transition"] = "opacity 1s ease-in-out";
+ innerLocalSplash.style["-o-transition"] = "opacity 1s ease-in-out";
window.setTimeout(function () {
- document.body.removeChild(localSplash);
- localSplash = null;
+ document.body.removeChild(innerLocalSplash);
+ innerLocalSplash = null;
}, 1000);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org