You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2010/06/25 14:49:50 UTC
[jira] Created: (SLING-1575) Authentication API and Handler
Improvements
Authentication API and Handler Improvements
-------------------------------------------
Key: SLING-1575
URL: https://issues.apache.org/jira/browse/SLING-1575
Project: Sling
Issue Type: Improvement
Components: API, Commons, Extensions
Reporter: Felix Meschberger
Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
* Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
* Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
* Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
* Extend the authentication handlers from the abstract handler
The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882572#action_12882572 ]
Felix Meschberger commented on SLING-1575:
------------------------------------------
Yes, but refining from that discussion in that only API usefull for general Sling Applications is moved to the API, while the more specific API like AuthenticationSupport and the SPI interfaces remain in Commons Auth.
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882559#action_12882559 ]
Justin Edelson commented on SLING-1575:
---------------------------------------
There was some mention of merging commons.auth into the engine bundle. Should that be done in concert with this issue?
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882569#action_12882569 ]
Felix Meschberger commented on SLING-1575:
------------------------------------------
@Justin: No this is about moving parts of commons auth API to the Sling API bundle.
Commons Auth was part of the engine bundle previously but to separate concerns, the commons auth bundle has been created and the respective code removed from the engine bundle
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-1575.
------------------------------------
Close after release
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1575:
-------------------------------------
Component/s: Authentication
(was: API)
(was: Extensions)
(was: Commons)
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1575:
-------------------------------------
Comment: was deleted
(was: It looks like there is a problem with the new ResourceUtil implementation [1].
While there is no problem in using Resource interface implementations compiled against the previous version (missing the methods) as long as the new methods are not used, there is a problem when the new ResourceUtil implementations depend on the new Resource interface methods.
The solution here is probably to not depend on the new Resource interface methods in the ResourceUtil methods but keep the implementations and refer to them from the AbstractResource implementation.
[1] http://markmail.org/message/i3huzv6uleruzazq)
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SLING-1575) Authentication API and
Handler Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892789#action_12892789 ]
Felix Meschberger edited comment on SLING-1575 at 7/27/10 10:15 AM:
--------------------------------------------------------------------
In Rev. 979706/979707 removed the @scr tags from the AbstractAuthenticationFormServlet. Implementations of this abstract class should setup themselves for SCR descriptor generation. This is in line with the AbstractAuthenticationHandler which also does not have the tags.
In Rev. 979711 added the @scr.service tag to the form servlets. In addition the AbstractAuthenticationHandler property name references have to be fully qualifed for the SCR plugin to find the class defining the constant.
was (Author: fmeschbe):
In Rev. 979706/979707 removed the @scr tags from the AbstractAuthenticationFormServlet. Implementations of this abstract class should setup themselves for SCR descriptor generation. This is in line with the AbstractAuthenticationHandler which also does not have the tags.
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892749#action_12892749 ]
Felix Meschberger commented on SLING-1575:
------------------------------------------
Rev. 979669: Adapt Form and OpenID authentication handler to use new abstract form servlet and authentication handler
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-1575.
--------------------------------------
Resolution: Fixed
Committed all required changes and Sling main build builds. Thus resolving this issue.
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-1575:
----------------------------------------
Assignee: Felix Meschberger
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1575:
-------------------------------------
Fix Version/s: Commons Auth 1.0.0
API 2.1.0
Schedule for API 2.1 and Commons Auth 1.0 release
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-1575.
--------------------------------------
Resolution: Fixed
Can be resolved again, reopened the wrong issue.
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892789#action_12892789 ]
Felix Meschberger commented on SLING-1575:
------------------------------------------
In Rev. 979706/979707 removed the @scr tags from the AbstractAuthenticationFormServlet. Implementations of this abstract class should setup themselves for SCR descriptor generation. This is in line with the AbstractAuthenticationHandler which also does not have the tags.
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882571#action_12882571 ]
Justin Edelson commented on SLING-1575:
---------------------------------------
OK. looking back at http://markmail.org/message/l5f6vbhxaiercnwp, I see Carsten was actually talking about merging commons.auth with sling.api, which it looks like you are basically doing.
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882568#action_12882568 ]
Felix Meschberger commented on SLING-1575:
------------------------------------------
Patch is available at: http://codereview.appspot.com/1690046/show
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892734#action_12892734 ]
Felix Meschberger commented on SLING-1575:
------------------------------------------
Applied the proposed changes in Rev. 979641
In Rev. 979648: Import o.a.s.api.auth package with an implementor's version range (bundle plugin will log warnings, but it works correctly) and fix the @scr.service tag to refer to the correct interface name in the SlingAuthenticator class
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-1575) Authentication API and Handler
Improvements
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reopened SLING-1575:
--------------------------------------
It looks like there is a problem with the new ResourceUtil implementation [1].
While there is no problem in using Resource interface implementations compiled against the previous version (missing the methods) as long as the new methods are not used, there is a problem when the new ResourceUtil implementations depend on the new Resource interface methods.
The solution here is probably to not depend on the new Resource interface methods in the ResourceUtil methods but keep the implementations and refer to them from the AbstractResource implementation.
[1] http://markmail.org/message/i3huzv6uleruzazq
> Authentication API and Handler Improvements
> -------------------------------------------
>
> Key: SLING-1575
> URL: https://issues.apache.org/jira/browse/SLING-1575
> Project: Sling
> Issue Type: Improvement
> Components: API, Commons, Extensions
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Commons Auth 1.0.0, API 2.1.0
>
>
> Proposing the following enhancement to the Commons Auth bundle as well as the two existing form based authentication handlers (Form Based Authentication Handler and OpenID Authentication Handler):
> * Create a new o.a.sling.api.auth package with the Authenticator interface and the NoAuthenticationHandler exception
> * Create an AbstractAuthenticationFormServlet and AbstractAuthenticationHandler in Commons Auth (o.a.sling.commons.auth.spi)
> * Extend the form servlets in the Form and OpenID handlers from the abstract form servlet
> * Extend the authentication handlers from the abstract handler
> The new o.a.sling.api.auth package is the current o.a.sling.commons.auth package without the AuthenticationSupport interface. The reason for this is, that the Authenticator interface can be used by Sling applications to request users to login. The AuthenticationSupport interface on the other hand is closed tied into the Commons Auth implementation and is not generally used by Sling Applications.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.