You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/26 16:27:17 UTC
Review Request 63268: Windows: Fixed variable casing in
`windows/os.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63268/
-----------------------------------------------------------
Review request for mesos, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
Repository: mesos
Description
-------
This changes the CamelCase to snake_case per the style guide for stout.
It also adds `::` to uses of `::GetLastError` where it was missing, and
includes `<vector>` because it was used but missing.
Diffs
-----
3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
Diff: https://reviews.apache.org/r/63268/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63268: Windows: Fixed variable casing in
`windows/os.hpp`.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63268/#review189340
-----------------------------------------------------------
Ship it!
Ship It!
- Jeff Coffler
On Oct. 26, 2017, 4:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63268/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This changes the CamelCase to snake_case per the style guide for stout.
> It also adds `::` to uses of `::GetLastError` where it was missing, and
> includes `<vector>` because it was used but missing.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
>
>
> Diff: https://reviews.apache.org/r/63268/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>