[incubator-uniffle] branch master updated: [MINOR] Simplify creating buffer logic (#227)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new b9bc7ce9 [MINOR] Simplify creating buffer logic (#227)
b9bc7ce9 is described below

commit b9bc7ce95da5c615ed5e9c01ca2a56eca0beac22
Author: Junfan Zhang <ju...@outlook.com>
AuthorDate: Fri Sep 16 19:49:45 2022 +0800

    [MINOR] Simplify creating buffer logic (#227)
    
    ### What changes were proposed in this pull request?
    [MINOR] Simplify creating buffer logic
    
    ### Why are the changes needed?
    Minor improvement to avoid duplicate code.
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    No need.
---
 .../java/org/apache/spark/shuffle/writer/WriterBuffer.java     | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriterBuffer.java b/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriterBuffer.java
index 6fb41975..a1427c71 100644
--- a/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriterBuffer.java
+++ b/client-spark/common/src/main/java/org/apache/spark/shuffle/writer/WriterBuffer.java
@@ -45,13 +45,9 @@ public class WriterBuffer {
         buffers.add(new WrappedBuffer(buffer, nextOffset));
         nextOffset = 0;
       }
-      if (length > bufferSize) {
-        buffer = new byte[length];
-        memoryUsed += length;
-      } else {
-        buffer = new byte[bufferSize];
-        memoryUsed += bufferSize;
-      }
+      int newBufferSize = Math.max(length, bufferSize);
+      buffer = new byte[newBufferSize];
+      memoryUsed += newBufferSize;
     }
 
     try {