You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ne...@apache.org on 2019/01/12 01:00:26 UTC

[incubator-pinot] branch fix_stats_file_realtime created (now 718096e)

This is an automated email from the ASF dual-hosted git repository.

nehapawar pushed a change to branch fix_stats_file_realtime
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.


      at 718096e  Change the realtime stats file to a new name

This branch includes the following new commits:

     new 718096e  Change the realtime stats file to a new name

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[incubator-pinot] 01/01: Change the realtime stats file to a new name

Posted by ne...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

nehapawar pushed a commit to branch fix_stats_file_realtime
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit 718096ed1c5b20c365b63d01490e847a8e70a724
Author: Neha Pawar <np...@linkedin.com>
AuthorDate: Fri Jan 11 17:00:03 2019 -0800

    Change the realtime stats file to a new name
---
 .../data/manager/realtime/RealtimeTableDataManager.java   |   2 +-
 .../realtime/impl/RealtimeSegmentStatsHistoryTest.java    |   4 ++--
 .../resources/data/realtime-segment-stats-history-v1.ser  | Bin 822 -> 0 bytes
 .../resources/data/realtime-segment-stats-history.ser     | Bin 0 -> 832 bytes
 4 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
index ff8a8b8..327c612 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
@@ -65,7 +65,7 @@ public class RealtimeTableDataManager extends BaseTableDataManager {
   private RealtimeSegmentStatsHistory _statsHistory;
   private final Semaphore _segmentBuildSemaphore;
 
-  private static final String STATS_FILE_NAME = "stats.ser";
+  private static final String STATS_FILE_NAME = "statsV2.ser";
   private static final String CONSUMERS_DIR = "consumers";
 
   // Topics tend to have similar cardinality for values across partitions consumed during the same time.
diff --git a/pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/RealtimeSegmentStatsHistoryTest.java b/pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/RealtimeSegmentStatsHistoryTest.java
index a1a3c79..09d9275 100644
--- a/pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/RealtimeSegmentStatsHistoryTest.java
+++ b/pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/RealtimeSegmentStatsHistoryTest.java
@@ -222,9 +222,9 @@ public class RealtimeSegmentStatsHistoryTest {
   // This test attempts to ensure that future modifications to RealtimeSegmentStatsHistory does not prevent the software
   // from reading data serialized by earlier versions. The serialized data has one segment, with 2 columns -- "v1col1" and
   // "v1col2".
-  //@Test
+  @Test
   public void testVersion1() throws Exception {
-    final String fileName = "realtime-segment-stats-history-v1.ser";
+    final String fileName = "realtime-segment-stats-history.ser";
     File v1StatsFile = new File(TestUtils.getFileFromResourceUrl(RealtimeSegmentStatsHistoryTest.class.getClassLoader().getResource("data")), fileName);
     RealtimeSegmentStatsHistory statsHistory = RealtimeSegmentStatsHistory.deserialzeFrom(v1StatsFile);
     RealtimeSegmentStatsHistory.SegmentStats segmentStats = statsHistory.getSegmentStatsAt(0);
diff --git a/pinot-core/src/test/resources/data/realtime-segment-stats-history-v1.ser b/pinot-core/src/test/resources/data/realtime-segment-stats-history-v1.ser
deleted file mode 100644
index e0f09dc..0000000
Binary files a/pinot-core/src/test/resources/data/realtime-segment-stats-history-v1.ser and /dev/null differ
diff --git a/pinot-core/src/test/resources/data/realtime-segment-stats-history.ser b/pinot-core/src/test/resources/data/realtime-segment-stats-history.ser
new file mode 100644
index 0000000..06519f8
Binary files /dev/null and b/pinot-core/src/test/resources/data/realtime-segment-stats-history.ser differ


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org