You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/23 22:48:00 UTC

[jira] [Work logged] (CAMEL-14771) Consider using the master branch tooling for 2.x and 3.0.x catalog construction

     [ https://issues.apache.org/jira/browse/CAMEL-14771?focusedWorklogId=408372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408372 ]

ASF GitHub Bot logged work on CAMEL-14771:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Mar/20 22:47
            Start Date: 23/Mar/20 22:47
    Worklog Time Spent: 10m 
      Work Description: djencks commented on pull request #3669: resolves CAMEL-14771: unambiguous property name and some more source info
URL: https://github.com/apache/camel/pull/3669
 
 
   NEEDS REVIEW AND CONSIDERATION!
   
   I've included:
   - PrepareCatalogMojo.java change property name so it may be configured (needed for use in 2.x branch). This also filters out some json files that should not be processed but are located in the 2.x branch.
   - a few catch-rethrow exceptions to add the file name of the problematic resource.  I needed these to figure out what was going wrong on the 2.x branch.
   
   Is this a good idea?
   
   Here's the configuration for the 2.x platforms/camel-catalog/pom.xml:
   ```
         <!-- generate and include all components in the catalog -->
         <plugin>
           <groupId>org.apache.camel</groupId>
           <artifactId>camel-package-maven-plugin</artifactId>
           <version>3.2.0-SNAPSHOT</version>
           <executions>
             <execution>
               <!-- prepare the catalog before the user guide / readme -->
               <goals>
                               <goal>prepare-catalog</goal>
                               <goal>prepare-user-guide</goal>
                               <goal>update-doc-component-list</goal>
                               <goal>prepare-parent-pom</goal>
                               <goal>prepare-release-pom</goal>
               </goals>
   	    <configuration>
   	      <coreLanguagesDir>${project.build.directory}/../../../camel-core</coreLanguagesDir>
   	    </configuration>
               <phase>process-resources</phase>
             </execution>
           </executions>
         </plugin>
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 408372)
    Remaining Estimate: 0h
            Time Spent: 10m

> Consider using the master branch tooling for 2.x and 3.0.x catalog construction
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-14771
>                 URL: https://issues.apache.org/jira/browse/CAMEL-14771
>             Project: Camel
>          Issue Type: Improvement
>          Components: website
>    Affects Versions: 3.1.0
>            Reporter: David Jencks
>            Priority: Major
>             Fix For: 3.2.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The 3.0.x branch includes the tooling needed to construct the components component index pages, but the 2.x branch does not.  Some slight modification and configuration of the master branch tooling allow it to be used for the 2.x index pages.  The modifications are roughly:
>  * excluding some json files that are not intended for the catalog
>  * changing some parameter names that are shared across mojos but have different meanings, so that they may be configured.
> I don't know if this is a good idea or not.  I only changed the one name that conflicts, but if we decide to do this changing some more would be a good idea.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)