[jira] [Commented] (DRILL-8296) Possible type mismatch bug in SplunkBatchReader

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628208#comment-17628208 ] 

ASF GitHub Bot commented on DRILL-8296:
---------------------------------------

jnturton opened a new pull request, #2700:
URL: https://github.com/apache/drill/pull/2700

   # [DRILL-8296](https://issues.apache.org/jira/browse/DRILL-8296): Possible type mismatch bug in SplunkBatchReader
   
   ## Description
   ```
         if (path.nameEquals("**")) {
           return true;
         } else {
           return specialFields.contains(path.getAsNamePart());
         }
   ```
   LGTM and IntelliJ both say that NamePart type does not match the type stored in specialFields collection. This change refactors the code handling special fields.
   
   ## Documentation
   N/A
   
   ## Testing
   Splunk plugin unit tests.
   




> Possible type mismatch bug in SplunkBatchReader
> -----------------------------------------------
>
>                 Key: DRILL-8296
>                 URL: https://issues.apache.org/jira/browse/DRILL-8296
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: splunk
>    Affects Versions: 1.20.2
>            Reporter: PJ Fanning
>            Assignee: James Turton
>            Priority: Minor
>             Fix For: 1.20.3
>
>
> {code:java}
>       if (path.nameEquals("**")) {
>         return true;
>       } else {
>         return specialFields.contains(path.getAsNamePart());
>       }
> {code}
> LGTM and IntelliJ both say that NamePart type does not match the type stored in specialFields collection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)