[GitHub] [logging-log4j2] rgoers commented on pull request #1058: Add triggerpolicy support for using current time

[GitBox <gi...@apache.org>]

rgoers commented on PR #1058:
URL: https://github.com/apache/logging-log4j2/pull/1058#issuecomment-1369844871

   I disagree with both the premise and the implementation of this change.
   
   1. By design size-based rollovers increment the index. They only update the time if no time-based triggering policy is configured. Time-based rollovers update the time, they reset the index to 1.
   2. When direct-write is in use the file is always created at the start of the interval, so the file name should align with what the default rollover policy will currently create.
   3. I don't normally use a date pattern on a size based file without a time-based trigger as the date/index won't make much sense together but if I did I would expect it to be from when the file is created. If that is not the case I could see correcting that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org