You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "greyp9 (via GitHub)" <gi...@apache.org> on 2023/06/14 17:50:05 UTC
[GitHub] [nifi] greyp9 opened a new pull request, #7379: NIFI-11690 - include extension info for SupportsSensitiveDynamicPrope…
greyp9 opened a new pull request, #7379:
URL: https://github.com/apache/nifi/pull/7379
…rties in C2 manifest
# Summary
[NIFI-11690](https://issues.apache.org/jira/browse/NIFI-11690)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #7379: NIFI-11690 - include extension info for SupportsSensitiveDynamicPrope…
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende commented on PR #7379:
URL: https://github.com/apache/nifi/pull/7379#issuecomment-1593290321
+1 looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende merged pull request #7379: NIFI-11690 - include extension info for SupportsSensitiveDynamicPrope…
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende merged PR #7379:
URL: https://github.com/apache/nifi/pull/7379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a diff in pull request #7379: NIFI-11690 - include extension info for SupportsSensitiveDynamicPrope…
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende commented on code in PR #7379:
URL: https://github.com/apache/nifi/pull/7379#discussion_r1230077915
##########
nifi-manifest/nifi-runtime-manifest-test/src/test/java/org/apache/nifi/runtime/manifest/TestRuntimeManifest.java:
##########
@@ -264,6 +265,7 @@ void testRuntimeManifest() throws IOException {
assertNotNull(routeOnAttributeDef.getDynamicRelationship().getDescription());
assertTrue(routeOnAttributeDef.getSupportsDynamicProperties());
+ assertTrue(routeOnAttributeDef.getSupportsSensitiveDynamicProperties());
Review Comment:
Ah nice, it looks good locally, will wait for CI builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a diff in pull request #7379: NIFI-11690 - include extension info for SupportsSensitiveDynamicPrope…
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende commented on code in PR #7379:
URL: https://github.com/apache/nifi/pull/7379#discussion_r1230069446
##########
nifi-manifest/nifi-runtime-manifest-test/src/test/java/org/apache/nifi/runtime/manifest/TestRuntimeManifest.java:
##########
@@ -264,6 +265,7 @@ void testRuntimeManifest() throws IOException {
assertNotNull(routeOnAttributeDef.getDynamicRelationship().getDescription());
assertTrue(routeOnAttributeDef.getSupportsDynamicProperties());
+ assertTrue(routeOnAttributeDef.getSupportsSensitiveDynamicProperties());
Review Comment:
Seems like this one is causing a test failure because RouteOnAttribute doesn't support sensitive dynamic properties. Probably have to locate a different definition for a component we know supports it, since all the ones currently in the test don't (I think).
```
[ERROR] Failures:
[ERROR] TestRuntimeManifest.testRuntimeManifest:268 expected: <true> but was: <false>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #7379: NIFI-11690 - include extension info for SupportsSensitiveDynamicPrope…
Posted by "greyp9 (via GitHub)" <gi...@apache.org>.
greyp9 commented on code in PR #7379:
URL: https://github.com/apache/nifi/pull/7379#discussion_r1230077060
##########
nifi-manifest/nifi-runtime-manifest-test/src/test/java/org/apache/nifi/runtime/manifest/TestRuntimeManifest.java:
##########
@@ -264,6 +265,7 @@ void testRuntimeManifest() throws IOException {
assertNotNull(routeOnAttributeDef.getDynamicRelationship().getDescription());
assertTrue(routeOnAttributeDef.getSupportsDynamicProperties());
+ assertTrue(routeOnAttributeDef.getSupportsSensitiveDynamicProperties());
Review Comment:
> Seems like this one is causing a test failure because RouteOnAttribute doesn't support sensitive dynamic properties. Probably have to locate a different definition for a component we know supports it, since all the ones currently in the test don't (I think).
>
> ```
> [ERROR] Failures:
> [ERROR] TestRuntimeManifest.testRuntimeManifest:268 expected: <true> but was: <false>
> ```
Yep, my bad. Looks like ExecuteSQL has the annotation; added an assertion for that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org