[GitHub] [samza] shanthoosh commented on a diff in pull request #1677: Add new SamzaApplicationMaster metric to track allocated containers buffered in AM

["shanthoosh (via GitHub)" <gi...@apache.org>]

shanthoosh commented on code in PR #1677:
URL: https://github.com/apache/samza/pull/1677#discussion_r1267105644


##########
samza-yarn/src/main/java/org/apache/samza/job/yarn/YarnClusterResourceManager.java:
##########
@@ -298,6 +298,7 @@ public void releaseResources(SamzaResource resource) {
       }
       amClient.releaseAssignedContainer(container.getId());
       allocatedResources.remove(resource);
+      metrics.decrementAllocatedContainersInBuffer();

Review Comment:
   Do we want to decrement this metric in the stopStreamProcessor method as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org