You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/12 00:35:14 UTC

[GitHub] [beam] angoenka commented on a change in pull request #12537: [BEAM-10200] Add optional experiment to enable heap dump through the …

angoenka commented on a change in pull request #12537:
URL: https://github.com/apache/beam/pull/12537#discussion_r468938985



##########
File path: sdks/python/apache_beam/runners/worker/worker_status.py
##########
@@ -152,7 +170,11 @@ def generate_status_response(self):
     all_status_sections = [
         _active_processing_bundles_state(self._bundle_process_cache)
     ] if self._bundle_process_cache else []
+
     all_status_sections.append(thread_dump())
+    if self._enable_heap_dump:
+      all_status_sections.append(heap_dump())

Review comment:
       Do we need a size limit here?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org