You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2005/06/27 09:32:00 UTC
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
kou@tigris.org wrote:
> Author: kou
> Date: Sun Jun 26 21:02:39 2005
> New Revision: 15177
>
> Modified:
> trunk/subversion/bindings/swig/ruby/svn/info.rb
>
> Log:
> Add debug print temporally.
"temporarily", not "temporally".
Also, If this is just a temporary change for debugging, why commit it at
all?
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
In <20...@jaa.iki.fi>
"Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn" on Tue, 28 Jun 2005 19:46:38 -0600,
Jani Averbach <ja...@jaa.iki.fi> wrote:
> > I tried the following environment but I can't reproduce.
> >
>
> *Shurg* I really don't know.
It's OK. I only want to show some informations. You doesn't
need to worry. Sorry for worrying you.
> > By the way, swig-rb test result has not been sent to svn-breakage
> > list yesterday. Jani, do you know what's happen?
>
> The last run was no-op (svn trunk r15181: NOOP...) because there
> weren't any code changes between this revision and the latest tested
> (15178:15181). So the system skipped that test run.
I see.
Thank you for the information.
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by Jani Averbach <ja...@jaa.iki.fi>.
On 2005-06-29 10:29+0900, Kouhei Sutou wrote:
> Jani Averbach wrote:
>
> > Here is a list what might be special in my system:
> >
> > - apr and apr-util has been compiled with memory debugging enabled:
> > "--enable-pool-debug=yes"
> > - I have hardware noexec stack in use
> > - The system is 64bit
>
> I tried the following environment but I can't reproduce.
>
> - apr and apr-util are compiled with --enable-pool-debug=yes
> - apr ver.: http://svn.apache.org/repos/asf/apr/apr/branches/0.9.x/
> - apr-util ver.: http://svn.apache.org/repos/asf/apr/apr-util/branches/0.9.x/
> - apr configure options: --enable-pool-debug=yes --disable-threads
> - apr-util configure options: --enable-pool-debug=yes
> - The system is 64 bit.
> - % uname -mrs # => FreeBSD 5.4-RELEASE-p2 amd64
*Shurg* I really don't know.
If you came up any others idea how to verify that my setup is ok,
please let me know.
> I don't know "hardware noexec stack", so I can't use it.
It is hardware level protection that stack isn't executable, I think
that FreeBSD uses it also, but I am not sure.
> By the way, swig-rb test result has not been sent to svn-breakage
> list yesterday. Jani, do you know what's happen?
The last run was no-op (svn trunk r15181: NOOP...) because there
weren't any code changes between this revision and the latest tested
(15178:15181). So the system skipped that test run.
BR, Jani
--
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
In <20...@jaa.iki.fi>
"Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn" on Tue, 28 Jun 2005 08:57:33 -0600,
Jani Averbach <ja...@jaa.iki.fi> wrote:
> Here is a list what might be special in my system:
>
> - apr and apr-util has been compiled with memory debugging enabled:
> "--enable-pool-debug=yes"
> - I have hardware noexec stack in use
> - The system is 64bit
I tried the following environment but I can't reproduce.
- apr and apr-util are compiled with --enable-pool-debug=yes
- apr ver.: http://svn.apache.org/repos/asf/apr/apr/branches/0.9.x/
- apr-util ver.: http://svn.apache.org/repos/asf/apr/apr-util/branches/0.9.x/
- apr configure options: --enable-pool-debug=yes --disable-threads
- apr-util configure options: --enable-pool-debug=yes
- The system is 64 bit.
- % uname -mrs # => FreeBSD 5.4-RELEASE-p2 amd64
I don't know "hardware noexec stack", so I can't use it.
By the way, swig-rb test result has not been sent to svn-breakage
list yesterday. Jani, do you know what's happen?
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
In <03...@chimaera>
"Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn" on Tue, 28 Jun 2005 17:08:33 +0100,
"Max Bowsher" <ma...@ukf.net> wrote:
> > But I don't know which is better way to do this. Should I
> > ask Jani to apply my patches or commit to trunk?
>
> Trunk's fine, I didn't realize it was for svn-breakage. I think I've done
> something similar myself, once.
>
> The best thing to do is to mention svn-breakage in the log message, so that
> anyone seeing it understands what is happening.
I see.
I have done.
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by Max Bowsher <ma...@ukf.net>.
Kouhei Sutou wrote:
> Hi,
>
> In <03...@chimaera>
> "Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn" on
> Mon,
> 27 Jun 2005 10:32:00 +0100, "Max Bowsher" <ma...@ukf.net> wrote:
>
>> Also, If this is just a temporary change for debugging, why commit it at
>> all?
>
> My answer is same as David's one.
>
> I'm debugging the problem that Ruby bindings courses
> segmentation fault on Jani's environment. But the problem
> doesn't occurred on my environment. So I'm embedding debug
> print statements and checking svn-breakage list.
>
> I can ask Jani to apply my patches but that costs Jani. So I
> decided that I committed some debug print statements. Now,
> Ruby bindings tests on Jani's environment are automatically
> executed with some debug print statements.
>
> But I don't know which is better way to do this. Should I
> ask Jani to apply my patches or commit to trunk?
Trunk's fine, I didn't realize it was for svn-breakage. I think I've done
something similar myself, once.
The best thing to do is to mention svn-breakage in the log message, so that
anyone seeing it understands what is happening.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by Jani Averbach <ja...@jaa.iki.fi>.
On 2005-06-28 23:33+0900, Kouhei Sutou wrote:
> "Max Bowsher" <ma...@ukf.net> wrote:
> > Also, If this is just a temporary change for debugging, why commit it at
> > all?
>
> My answer is same as David's one.
>
> I'm debugging the problem that Ruby bindings courses
> segmentation fault on Jani's environment. But the problem
> doesn't occurred on my environment.
Here is a list what might be special in my system:
- apr and apr-util has been compiled with memory debugging enabled:
"--enable-pool-debug=yes"
- I have hardware noexec stack in use
- The system is 64bit
> So I'm embedding debug
> print statements and checking svn-breakage list.
>
> I can ask Jani to apply my patches but that costs Jani. So I
> decided that I committed some debug print statements. Now,
> Ruby bindings tests on Jani's environment are automatically
> executed with some debug print statements.
>
> But I don't know which is better way to do this. Should I
> ask Jani to apply my patches or commit to trunk?
There are few options:
1) Use trunk
pros: I don't have to do anything, it is easy for you
cons: Trunk will be littered with debug statements, currently ruby
bindings testing won't work on trunk (only get_diff is tested)
2) Use special branch for testing
pros: I don't have to do anything (after initial setup), trunk will
stay clean
cons: it is semi easy for you (you have to sync with trunk)
3) Send patches to me
pros: No disturbance in svn tree at all
cons: Most laborious for you and me, we/I can screw up something with
patches so I am not testing what you expect me to test
I favor 1 or 2, the initial setup for option 2 is fairly easy one, and
I could easily set the system a way that for this special purpose
branch only ruby bindings will be tested.
Kou and the rest of the team, please let me know what you like to do.
BR, Jani
--
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by David James <ja...@gmail.com>.
On 6/28/05, Kouhei Sutou <ko...@cozmixng.org> wrote:
> But I don't know which is better way to do this. Should I
> ask Jani to apply my patches or commit to trunk?
Personally, I recommend the following approach: Instead of adding
print statements, add "debugprint" statements. Set up a debugprint
function which only prints when debugging is enabled. Leave these
debugprint statements in the source code permanently and they will
always be helpful whenever you are debugging.
The developers of the Log4j project for Java present a convincing
argument for including logging (or debugging) code in your Ruby (or
Java) projects. Read it below.
"Inserting log statements into your code is a low-tech method for
debugging it. It may also be the only way because debuggers are not
always available or applicable. This is often the case for distributed
applications.
On the other hand, some people argue that log statements pollute
source code and decrease legibility. (We believe that the contrary is
true). In the Java [or Ruby] language where a preprocessor is not
available, log statements increase the size of the code and reduce its
speed, even when logging is turned off. Given that a reasonably sized
application may contain thousands of log statements, speed is of
particular importance.
Logging equips the developer with detailed context for application
failures. On the other hand, testing provides quality assurance and
confidence in the application. Logging and testing should not be
confused. They are complementary. When logging is wisely used, it can
prove to be an essential tool. ...
Logging equips the developer with detailed context for application
failures. On the other hand, testing provides quality assurance and
confidence in the application. Logging and testing should not be
confused. They are complementary. When logging is wisely used, it can
prove to be an essential tool."
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
In <03...@chimaera>
"Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn" on Mon, 27 Jun 2005 10:32:00 +0100,
"Max Bowsher" <ma...@ukf.net> wrote:
> Also, If this is just a temporary change for debugging, why commit it at
> all?
My answer is same as David's one.
I'm debugging the problem that Ruby bindings courses
segmentation fault on Jani's environment. But the problem
doesn't occurred on my environment. So I'm embedding debug
print statements and checking svn-breakage list.
I can ask Jani to apply my patches but that costs Jani. So I
decided that I committed some debug print statements. Now,
Ruby bindings tests on Jani's environment are automatically
executed with some debug print statements.
But I don't know which is better way to do this. Should I
ask Jani to apply my patches or commit to trunk?
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r15177 - trunk/subversion/bindings/swig/ruby/svn
Posted by David James <ja...@gmail.com>.
On 6/27/05, Max Bowsher <ma...@ukf.net> wrote:
> Also, If this is just a temporary change for debugging, why commit it at
> all?
Jani Averbach's test box is reporting errors on the svn-breakage list.
It is difficult to debug the cause of this problem remotely, so Kou
has added print statements. If we can find a way to only run the print
statements when debug mode is enabled, we may want to keep those print
statements in there permanently. Any thoughts on the best way to do
this?
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org