You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/04/05 06:28:54 UTC
Review Request 70400: Added capabilities and evolve/devolve helpers
for CSI v1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70400/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Bugs: MESOS-9623
https://issues.apache.org/jira/browse/MESOS-9623
Repository: mesos
Description
-------
This patch adds capability helper structures for CSI v1 services, and
evolve/devolve helpers to convert between CSI v1 protobufs and their
unversioned counterparts.
Diffs
-----
src/CMakeLists.txt af3715a060b677da86d6d9a56b360f17be2bd0d3
src/Makefile.am a80044448563b3507d08a81857097ba4a39210fe
src/csi/v1_utils.hpp PRE-CREATION
src/csi/v1_utils.cpp PRE-CREATION
src/tests/csi_utils_tests.cpp b9d0ca809734839db49b174ef8d253563a41e7fd
Diff: https://reviews.apache.org/r/70400/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70400: Added capabilities and evolve/devolve
helpers for CSI v1.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70400/#review214461
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On April 5, 2019, 8:28 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70400/
> -----------------------------------------------------------
>
> (Updated April 5, 2019, 8:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9623
> https://issues.apache.org/jira/browse/MESOS-9623
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds capability helper structures for CSI v1 services, and
> evolve/devolve helpers to convert between CSI v1 protobufs and their
> unversioned counterparts.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt af3715a060b677da86d6d9a56b360f17be2bd0d3
> src/Makefile.am a80044448563b3507d08a81857097ba4a39210fe
> src/csi/v1_utils.hpp PRE-CREATION
> src/csi/v1_utils.cpp PRE-CREATION
> src/tests/csi_utils_tests.cpp b9d0ca809734839db49b174ef8d253563a41e7fd
>
>
> Diff: https://reviews.apache.org/r/70400/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70400: Added capabilities and evolve/devolve
helpers for CSI v1.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70400/
-----------------------------------------------------------
(Updated April 9, 2019, 6:05 a.m.)
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Changes
-------
Addressed Benjamin's comments in r/70399.
Bugs: MESOS-9623
https://issues.apache.org/jira/browse/MESOS-9623
Repository: mesos
Description
-------
This patch adds capability helper structures for CSI v1 services, and
evolve/devolve helpers to convert between CSI v1 protobufs and their
unversioned counterparts.
Diffs (updated)
-----
src/CMakeLists.txt af3715a060b677da86d6d9a56b360f17be2bd0d3
src/Makefile.am a80044448563b3507d08a81857097ba4a39210fe
src/csi/v1_utils.hpp PRE-CREATION
src/csi/v1_utils.cpp PRE-CREATION
src/tests/csi_utils_tests.cpp b9d0ca809734839db49b174ef8d253563a41e7fd
Diff: https://reviews.apache.org/r/70400/diff/2/
Changes: https://reviews.apache.org/r/70400/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao