You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/15 22:29:26 UTC
[GitHub] [airflow] khalidmammadov opened a new pull request #20330: Fixing MyPy issues inside airflow/secrets and airflow/security
khalidmammadov opened a new pull request #20330:
URL: https://github.com/apache/airflow/pull/20330
Part of: #19891
- Since `yaml.MarkedYAMLError.problem_mark` attribute is optional and can be `None` this check will ensure it will not fail to access `line` attribute of `problem_mark`
- `principal` parameter of the renew_from_kt is Optional. Later code takes care of it by fetching the default principal from settings but this part is still referring to parameter value.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20330: Fixing MyPy issues inside airflow/secrets and airflow/security
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20330:
URL: https://github.com/apache/airflow/pull/20330#issuecomment-996264902
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20330: Fixing MyPy issues inside airflow/secrets and airflow/security
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20330:
URL: https://github.com/apache/airflow/pull/20330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org