[GitHub] [incubator-pinot] fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in

[GitBox <gi...@apache.org>]

fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in
URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-496027439
 
 
   This is for just for Ubuntu travis image. We should point people to thrift page(https://thrift.apache.org/docs/install/) for build instruction based on their OS.
   
   Sent from my iPhone
   
   > On May 26, 2019, at 10:37, Kishore Gopalakrishna <no...@github.com> wrote:
   > 
   > @kishoreg commented on this pull request.
   > 
   > Nice to see the build pass. Let us update the build instructions as well.
   > 
   > @Jackie-Jiang, does this look ok?
   > 
   > In .travis.yml:
   > 
   > > @@ -20,6 +20,13 @@ cache:
   >  addons:
   >    firefox: latest
   >  
   > +before_install:
   > +  - sudo apt-get update -qq
   > Will this be part of build instructions as well. If so, should we move these into install_thrift.sh script?
   > 
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub, or mute the thread.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org