You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/24 03:36:26 UTC

[GitHub] [tvm] jinhongyii opened a new pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

jinhongyii opened a new pull request #9100:
URL: https://github.com/apache/tvm/pull/9100


   Add a fallback mechanism in tir::Fuse if DetectIterMap can't handle the input and throw an error
   cc @junrushao1994 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jinhongyii commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
jinhongyii commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-927004958


   sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-927004840


   @jinhongyii would you like to coordinate with @spectrometerHBH and get DetectIterMap fixed foundamentally? Here is what we can do: 
   
   1. Make a minimal reproducible example for DetectIterMap to crash, and then convert it to a regression test for it
   2. Fix the issue in fusion and make a regression test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jinhongyii commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
jinhongyii commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-927019144


   I'm not sure. But if DetectIterMap is fixed, both split and fuse will not have such error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-926348920


   CC @spectrometerHBH 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jinhongyii commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
jinhongyii commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-927004390


   The new unittest will fail until the DetectIterMap is fixed because DebugVerify will call DetectIterMap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Hzfengsy commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-927018893


   Will the same error happens in `split`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Hzfengsy commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-930708601


   @jinhongyii Can you update the PR then we can merge it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-926327274


   1. Is it possible to fix DetectIterMap instead of using a broad try-catch?
   2. Please add a regression test for every bug fix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jinhongyii commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
jinhongyii commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-935301443


   OK. Let's close this PR and let @spectrometerHBH open a new one after he adds a check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jinhongyii closed pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
jinhongyii closed pull request #9100:
URL: https://github.com/apache/tvm/pull/9100


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-935296712


   Per offline discussion with @spectrometerHBH:
   
   - `DetectIterMap` assumes that there isn't any iter whose extent depends on other iters, and this particular case doesn't satisfy this constraint, so it failed miserably without good error message.
   - We might want to fix the issue by adding sanity check in `DetectIterMap`
   
   CC: @jinhongyii 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9100: [TensorIR][Bugfix] Fallback Mechanism in Fuse for failure of DetectIterMap

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9100:
URL: https://github.com/apache/tvm/pull/9100#issuecomment-934549086


   Ping @spectrometerHBH 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org