[jira] [Comment Edited] (OAK-1973) IndexUpdate traverses the data nodes under index nodes

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063464#comment-14063464 ] 

Chetan Mehrotra edited comment on OAK-1973 at 7/16/14 3:05 PM:
---------------------------------------------------------------

[~jukkaz] Should IndexUpdate be wrapped with VisibleEditor?

{noformat}
             IndexUpdate indexUpdate =
                     new IndexUpdate(provider, name, after, builder, callback);
             CommitFailedException exception =
-                    EditorDiff.process(indexUpdate, before, after);
+                    EditorDiff.process(VisibleEditor.wrap(indexUpdate), before, after);
             if (exception != null) {
                 throw exception;
             }
{noformat}


was (Author: chetanm):
[~jukkaz] Should IndexUpdate be wrapped with VisibleEditor?

> IndexUpdate traverses the data nodes under index nodes
> ------------------------------------------------------
>
>                 Key: OAK-1973
>                 URL: https://issues.apache.org/jira/browse/OAK-1973
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Chetan Mehrotra
>
> AsyncIndexUpdate uses IndexUpdate class as Editor and passes it to EditorDiff. IndexUpdate insternally wraps all the IndexEditors with VisibileEditor such that they do not traverse the invisible nodes (like :data). However IndexUpdate itself is not wrapped with VisibileEditor due to which it has to traverse all the Index data also for diff.
> Ideally IndexUpdate itself should be wrapped with VisibileEditor



--
This message was sent by Atlassian JIRA
(v6.2#6252)