[jira] [Commented] (GEODE-4722) Code Improvement: Refactor CliUtil

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374756#comment-16374756 ] 

ASF subversion and git services commented on GEODE-4722:
--------------------------------------------------------

Commit df093b5b8f2d1bee549e0b76472b4fcdd51ddc7f in geode's branch refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=df093b5 ]

GEODE-4722: Refactor CliUtil (#1487)

* Reorder methods, grouped by similar functionality.
* Replace .stackTraceToString and .contains with Apache Commons methods.
* Moved getClientIdFromCacheClientProxy to only class that calls it.
* Move arrayToString from CliUtil to sensible StringUtils.  Moved associated test.
* Refactor CliUtil methods.

> Code Improvement: Refactor CliUtil
> ----------------------------------
>
>                 Key: GEODE-4722
>                 URL: https://issues.apache.org/jira/browse/GEODE-4722
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This class could use some cleaning.  Many methods are unused, some trivially replaced by Apache Commons libraries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)