You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/13 03:02:04 UTC
[GitHub] [submarine] yuanzac commented on a change in pull request #226:
SUBMARINE-84. Set random port in TF_CONFIG
yuanzac commented on a change in pull request #226: SUBMARINE-84. Set random port in TF_CONFIG
URL: https://github.com/apache/submarine/pull/226#discussion_r392007909
##########
File path: submarine-server/server-submitter/submitter-yarnservice/src/main/java/org/apache/submarine/server/submitter/yarnservice/tensorflow/TensorFlowConfigEnvGenerator.java
##########
@@ -19,15 +19,18 @@
package org.apache.submarine.server.submitter.yarnservice.tensorflow;
+import java.io.IOException;
+import org.apache.hadoop.net.ServerSocketUtil;
import org.apache.submarine.commons.runtime.conf.Envs;
import org.apache.submarine.server.submitter.yarnservice.YarnServiceUtils;
public class TensorFlowConfigEnvGenerator {
public static String getTFConfigEnv(String componentName, int nWorkers,
- int nPs, String serviceName, String userName, String domain) {
+ int nPs, String serviceName, String userName, String domain) throws IOException {
String commonEndpointSuffix = YarnServiceUtils
- .getDNSNameCommonSuffix(serviceName, userName, domain, 8000);
+ .getDNSNameCommonSuffix(serviceName, userName, domain,
Review comment:
From my understanding, tensorflow config is generated before NM starts TF job worker containers. So the random port still may conflict with the ports on NM node. If the port is generated by NM, then the port conflictions would be resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org