[GitHub] [beam] lostluck commented on a change in pull request #15410: [BEAM-10277] Encoding position initial implementation

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #15410:
URL: https://github.com/apache/beam/pull/15410#discussion_r730990650



##########
File path: sdks/go/test/regression/coders/fromyaml/fromyaml.go
##########
@@ -83,11 +88,13 @@ func (s *Spec) testStandardCoder() (err error) {
 		log.Printf("skipping unimplemented coder urn: %v", s.Coder.Urn)
 		return nil
 	}
-	// TODO(BEAM-9615): Support Logical types, and produce a better error message.
-	if strings.Contains(s.Coder.Payload, "logical") {
-		log.Printf("skipping coder with logical type. Unsupported in the Go SDK for now. Payload: %v", s.Coder.Payload)
-		return nil
+	for _, c := range filteredCases {
+		if strings.Contains(s.Coder.Payload, c.filter) {
+			log.Printf("skipping coder case. Unsupported in the Go SDK for now: %v Payload: %v", c.reason, s.Coder.Payload)
+			return nil
+		}

Review comment:
       LGTM




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org