[jira] [Work logged] (GOBBLIN-1516) Only schedule TaskMetricsUpdateder when metric-reporting is enabled by config

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1516?focusedWorklogId=637888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637888 ]

ASF GitHub Bot logged work on GOBBLIN-1516:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Aug/21 21:08
            Start Date: 13/Aug/21 21:08
    Worklog Time Spent: 10m 
      Work Description: autumnust opened a new pull request #3365:
URL: https://github.com/apache/gobblin/pull/3365


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   https://issues.apache.org/jira/browse/GOBBLIN-1516
   
   
   ### Description
   This PR contains two parts: 
   - Rename `Optional<ScheduledThreadPoolExecutor> writerMetricsUpdater` to be `writerMetricsUpdateExecutor` which is more accurate. The original name collide with `WriterMetricsUpdater` class which is the actual Runnable to be scheduled. 
   - Within `registerNewTask`, only schedule the `TaskMetricsUpdater` if `metrics.enabled` is true. The `TaskMetricsUpdater` holds a reference to `Task` object and `TaskMetricsUpdater` is only terminated/removed after commit. As a result, when there are a large number of tasks being executed, all of them will only be GC'ed after commit phase. This is particularly not friendly to `AsyncDataWriter` when there are data being buffer until commit. For such application, we might consider disable the writer metric reporting to exchange for more efficient heap usage.
   
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 637888)
    Remaining Estimate: 0h
            Time Spent: 10m

> Only schedule TaskMetricsUpdateder when metric-reporting is enabled by config
> -----------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1516
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1516
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)