You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by sijie <gi...@git.apache.org> on 2017/06/30 01:07:56 UTC
[GitHub] bookkeeper pull request #220: BOOKKEEPER-1095: Server and Client Side Change...
GitHub user sijie opened a pull request:
https://github.com/apache/bookkeeper/pull/220
BOOKKEEPER-1095: Server and Client Side Changes
Descriptions of the changes in this PR:
- changes on FileInfo to support notifications on LAC changes
- a new ReadEntryLongPollV3 processor to process readEntry requests with long poll flags
- a new public API for long poll: readLastConfirmedAndEntry. if it is reading beyond the LAC, it will become a long poll request and wait for advancing LAC on bookie side; if it isn't reading beyond the LAC it will be normal reads.
- also have a speculative mechanism for long poll reads.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/bookkeeper BOOKKEEPER-1094
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #220
----
commit 48e88fc1be0c2efee858144ce7c1288d947a2b15
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-21T21:12:45Z
First attempt for porting long poll changes on client and server
commit 87fc9989d3fe3858c9c006413e028b0f78122ddb
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-29T22:28:53Z
Merge branch 'master' into BOOKKEEPER-1094
commit 973e5be4c4f636c9f9ddb7898ed0794a3891103e
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-30T01:02:32Z
BOOKKEEPER-1094: Long Poll - Server and Client Side Changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side C...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/220
@eolivelli I think the best way to do 'tailing' is to using the distributedlog library. it handles fetch and deals with the switch between normal reads and long poll reads when detecting lac is advancing. once this change is in, distributedlog should be compatible with current community master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #220: BOOKKEEPER-1095: Long Poll - Server and Client Side C...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/220
@sijie awesome
I hope that "simple clients" in the future will be able to leverage such powerful feature without having to add new "coordination services middlewares". Let's discuss this in a separate thread.
I have never tried to use "really" DistributedLog, I will give it a try.
I am really happy with having it merged in BK ! Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---