You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/12/06 10:28:31 UTC
[PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
amaliujia opened a new pull request, #44206:
URL: https://github.com/apache/spark/pull/44206
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
We can have a `foreachWithSubqueries` which also traverse the subqueries in the query plan.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Add a new way to access subqueries in the query plan.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1421676245
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala:
##########
@@ -145,4 +146,16 @@ class LogicalPlanSuite extends SparkFunSuite {
assert(query.where(Literal.FalseLiteral).maxRows.contains(0))
assert(query.where(Literal.FalseLiteral).maxRowsPerPartition.contains(0))
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val input = UnresolvedRelation(Seq("subquery_table"))
+ val input2 = UnresolvedRelation(Seq("t"))
+ val plan = Project(Seq(Alias(ScalarSubquery(input), "s")()), input2)
+ val cache = scala.collection.mutable.Set[String]()
+ plan.foreachWithSubqueries {
+ case UnresolvedRelation(iden, _, _) => cache.add(iden.mkString("."))
Review Comment:
What I mean is using
```
/** Returns a `.` separated name for this relation. */
def tableName: String = multipartIdentifier.quoted
override def name: String = tableName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1417751426
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4709,6 +4710,17 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
val df6 = df3.join(df2, col("df3.zaak_id") === col("df2.customer_id"), "outer")
df5.crossJoin(df6)
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val sql = "SELECT * FROM t WHERE col_t in (SELECT * FROM subquery_table)"
+ val plan = spark.sessionState.sqlParser.parsePlan(sql)
+ val cache = scala.collection.mutable.Set[String]()
+ plan.foreachWithSubqueries {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1421248561
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala:
##########
@@ -145,4 +146,16 @@ class LogicalPlanSuite extends SparkFunSuite {
assert(query.where(Literal.FalseLiteral).maxRows.contains(0))
assert(query.where(Literal.FalseLiteral).maxRowsPerPartition.contains(0))
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val input = UnresolvedRelation(Seq("subquery_table"))
+ val input2 = UnresolvedRelation(Seq("t"))
+ val plan = Project(Seq(Alias(ScalarSubquery(input), "s")()), input2)
Review Comment:
Super nit: this plan is actually invalid as `ScalarSubquery` requires the plan to return at least one row. Maybe `Exists` is better for testing, we can use it in `Filter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #44206:
URL: https://github.com/apache/spark/pull/44206#issuecomment-1842604715
@cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1421248570
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala:
##########
@@ -145,4 +146,16 @@ class LogicalPlanSuite extends SparkFunSuite {
assert(query.where(Literal.FalseLiteral).maxRows.contains(0))
assert(query.where(Literal.FalseLiteral).maxRowsPerPartition.contains(0))
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val input = UnresolvedRelation(Seq("subquery_table"))
+ val input2 = UnresolvedRelation(Seq("t"))
+ val plan = Project(Seq(Alias(ScalarSubquery(input), "s")()), input2)
+ val cache = scala.collection.mutable.Set[String]()
Review Comment:
```suggestion
val tableNames = scala.collection.mutable.Set[String]()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add `foreachWithSubqueries` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44206:
URL: https://github.com/apache/spark/pull/44206#issuecomment-1849099986
Thank you, @amaliujia , @cloud-fan , @beliefer .
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1421676784
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala:
##########
@@ -145,4 +146,16 @@ class LogicalPlanSuite extends SparkFunSuite {
assert(query.where(Literal.FalseLiteral).maxRows.contains(0))
assert(query.where(Literal.FalseLiteral).maxRowsPerPartition.contains(0))
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val input = UnresolvedRelation(Seq("subquery_table"))
+ val input2 = UnresolvedRelation(Seq("t"))
+ val plan = Project(Seq(Alias(ScalarSubquery(input), "s")()), input2)
+ val cache = scala.collection.mutable.Set[String]()
+ plan.foreachWithSubqueries {
+ case UnresolvedRelation(iden, _, _) => cache.add(iden.mkString("."))
Review Comment:
ah I see :) done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1421252671
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala:
##########
@@ -145,4 +146,16 @@ class LogicalPlanSuite extends SparkFunSuite {
assert(query.where(Literal.FalseLiteral).maxRows.contains(0))
assert(query.where(Literal.FalseLiteral).maxRowsPerPartition.contains(0))
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val input = UnresolvedRelation(Seq("subquery_table"))
+ val input2 = UnresolvedRelation(Seq("t"))
+ val plan = Project(Seq(Alias(ScalarSubquery(input), "s")()), input2)
+ val cache = scala.collection.mutable.Set[String]()
+ plan.foreachWithSubqueries {
+ case UnresolvedRelation(iden, _, _) => cache.add(iden.mkString("."))
Review Comment:
How about using `name`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1417495736
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4709,6 +4710,17 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
val df6 = df3.join(df2, col("df3.zaak_id") === col("df2.customer_id"), "outer")
df5.crossJoin(df6)
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val sql = "SELECT * FROM t WHERE col_t in (SELECT * FROM subquery_table)"
+ val plan = spark.sessionState.sqlParser.parsePlan(sql)
+ val cache = scala.collection.mutable.Set[String]()
+ plan.foreachWithSubqueries {
Review Comment:
If this is a unit test, let's move it `LogicalPlanSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #44206:
URL: https://github.com/apache/spark/pull/44206#issuecomment-1847998786
@cloud-fan I updated the test case. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add `foreachWithSubqueries` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44206: [SPARK-46285][SQL] Add `foreachWithSubqueries`
URL: https://github.com/apache/spark/pull/44206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46285][SQL] Add foreachWithSubqueries [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #44206:
URL: https://github.com/apache/spark/pull/44206#discussion_r1421608706
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala:
##########
@@ -145,4 +146,16 @@ class LogicalPlanSuite extends SparkFunSuite {
assert(query.where(Literal.FalseLiteral).maxRows.contains(0))
assert(query.where(Literal.FalseLiteral).maxRowsPerPartition.contains(0))
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val input = UnresolvedRelation(Seq("subquery_table"))
+ val input2 = UnresolvedRelation(Seq("t"))
+ val plan = Project(Seq(Alias(ScalarSubquery(input), "s")()), input2)
Review Comment:
Dot it. Done.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala:
##########
@@ -145,4 +146,16 @@ class LogicalPlanSuite extends SparkFunSuite {
assert(query.where(Literal.FalseLiteral).maxRows.contains(0))
assert(query.where(Literal.FalseLiteral).maxRowsPerPartition.contains(0))
}
+
+ test("SPARK-46285: foreachWithSubqueries") {
+ val input = UnresolvedRelation(Seq("subquery_table"))
+ val input2 = UnresolvedRelation(Seq("t"))
+ val plan = Project(Seq(Alias(ScalarSubquery(input), "s")()), input2)
+ val cache = scala.collection.mutable.Set[String]()
+ plan.foreachWithSubqueries {
+ case UnresolvedRelation(iden, _, _) => cache.add(iden.mkString("."))
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org