You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/14 15:04:40 UTC

[GitHub] [arrow] msathis opened a new pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

msathis opened a new pull request #10026:
URL: https://github.com/apache/arrow/pull/10026


   I have placed it in the `ui/scheduler` directory. You can run it using `yarn && yarn start` from within that directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] msathis commented on a change in pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
msathis commented on a change in pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#discussion_r614099493



##########
File path: rust/ballista/ui/scheduler/README.md
##########
@@ -0,0 +1,26 @@
+# Ballista UI
+
+
+## Available Scripts
+
+In the project directory, you can run:
+
+### `yarn start`

Review comment:
       Hi @andygrove , [Yarn](https://yarnpkg.com/) is a package manager for node js similar (or alternative) to npm. I plan to add docker compose files, but for local development using yarn or npm is better because they provide hot reloading.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] msathis commented on a change in pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
msathis commented on a change in pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#discussion_r614130042



##########
File path: rust/ballista/ui/scheduler/README.md
##########
@@ -0,0 +1,26 @@
+# Ballista UI
+
+
+## Available Scripts
+
+In the project directory, you can run:
+
+### `yarn start`

Review comment:
       I have seen people having the same confusion between Hadoop yarn & node js yarn. I will add the link to yarn website to clear because most people here are from Hadoop background. Yarn is much faster than npm, does deduplication well, pinned resolutions (similar to Cargo.lock, it has yarn.lock) etc. Though npm is catching up these days.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#issuecomment-820640867


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/10026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10026](https://codecov.io/gh/apache/arrow/pull/10026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a958130) into [master](https://codecov.io/gh/apache/arrow/commit/1ed681912be7246695cdd938ea632e1751403f67?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ed6819) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head a958130 differs from pull request most recent head 601cd43. Consider uploading reports for the commit 601cd43 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/10026/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow/pull/10026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10026      +/-   ##
   ==========================================
   + Coverage   78.68%   78.70%   +0.01%     
   ==========================================
     Files         285      286       +1     
     Lines       64035    64215     +180     
   ==========================================
   + Hits        50388    50538     +150     
   - Misses      13647    13677      +30     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/10026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/buffer/mutable.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyL211dGFibGUucnM=) | `83.89% <0.00%> (-3.84%)` | :arrow_down: |
   | [rust/arrow/src/buffer/immutable.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyL2ltbXV0YWJsZS5ycw==) | `97.29% <0.00%> (-0.56%)` | :arrow_down: |
   | [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `92.60% <0.00%> (-0.23%)` | :arrow_down: |
   | [rust/arrow/src/compute/kernels/boolean.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2Jvb2xlYW4ucnM=) | `97.63% <0.00%> (-0.12%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `94.66% <0.00%> (-0.11%)` | :arrow_down: |
   | [rust/arrow/src/datatypes/types.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzL3R5cGVzLnJz) | `88.88% <0.00%> (ø)` | |
   | [rust/arrow/src/temporal\_conversions.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9hcnJvdy9zcmMvdGVtcG9yYWxfY29udmVyc2lvbnMucnM=) | `100.00% <0.00%> (ø)` | |
   | [rust/ballista/rust/scheduler/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9iYWxsaXN0YS9ydXN0L3NjaGVkdWxlci9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | |
   | [rust/ballista/rust/core/src/serde/scheduler/mod.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9iYWxsaXN0YS9ydXN0L2NvcmUvc3JjL3NlcmRlL3NjaGVkdWxlci9tb2QucnM=) | `0.00% <0.00%> (ø)` | |
   | [rust/ballista/rust/scheduler/src/api/mod.rs](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVzdC9iYWxsaXN0YS9ydXN0L3NjaGVkdWxlci9zcmMvYXBpL21vZC5ycw==) | `0.00% <0.00%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/arrow/pull/10026/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/10026?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/10026?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ab3a08c...601cd43](https://codecov.io/gh/apache/arrow/pull/10026?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on a change in pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#discussion_r614103248



##########
File path: rust/ballista/ui/scheduler/README.md
##########
@@ -0,0 +1,26 @@
+# Ballista UI
+
+
+## Available Scripts
+
+In the project directory, you can run:
+
+### `yarn start`

Review comment:
       Thanks, and what is the benefit of yarn over npm here? Sorry for the basic questions but I do not have experience in this ecosystem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on a change in pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#discussion_r614103546



##########
File path: rust/ballista/ui/scheduler/README.md
##########
@@ -0,0 +1,26 @@
+# Ballista UI
+
+
+## Available Scripts
+
+In the project directory, you can run:
+
+### `yarn start`

Review comment:
       I'm only familiar with yarn in the context of running Spark clusters in yarn.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#issuecomment-819798519


   https://issues.apache.org/jira/browse/ARROW-12380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] msathis commented on a change in pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
msathis commented on a change in pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#discussion_r614275631



##########
File path: rust/ballista/ui/scheduler/README.md
##########
@@ -0,0 +1,26 @@
+# Ballista UI
+
+
+## Available Scripts
+
+In the project directory, you can run:
+
+### `yarn start`

Review comment:
       Done. Added a link to yarnpkg.com




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on a change in pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#discussion_r614092643



##########
File path: rust/ballista/ui/scheduler/README.md
##########
@@ -0,0 +1,26 @@
+# Ballista UI
+
+
+## Available Scripts
+
+In the project directory, you can run:
+
+### `yarn start`

Review comment:
       I'm curious ... why Yarn? 
   
   If we want to support yarn then we should add some documentation here such as "What is Yarn" and "How to install Yarn" but I am concerned that adding Yarn here implies we need to support Ballista on Yarn as well.
   
   What would the alternatives be here for local testing? Cargo run? Docker compose?
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#issuecomment-820822367


   @msathis Could you rebase against master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] msathis commented on pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
msathis commented on pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#issuecomment-821101954


   Updated with the latest master. We can merge it if all good :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] msathis commented on pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
msathis commented on pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#issuecomment-819668534


   <img width="1790" alt="Screenshot 2021-04-14 at 10 22 46 PM" src="https://user-images.githubusercontent.com/2977899/114748895-fc044100-9d6f-11eb-96f2-829a2121d4f3.png">
   
   This is how it looks right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #10026:
URL: https://github.com/apache/arrow/pull/10026


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] msathis edited a comment on pull request #10026: ARROW-12380: [Rust] [Ballista] Basic scheduler ui

Posted by GitBox <gi...@apache.org>.
msathis edited a comment on pull request #10026:
URL: https://github.com/apache/arrow/pull/10026#issuecomment-819668534


   <img width="1790" alt="Screenshot 2021-04-14 at 10 22 46 PM" src="https://user-images.githubusercontent.com/2977899/114748895-fc044100-9d6f-11eb-96f2-829a2121d4f3.png">
   
   This is how it looks right now. @andygrove 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org