[GitHub] [arrow] pitrou commented on a change in pull request #7202: ARROW-8825: [C++] Fix compilation for Wunused-paraemter flag

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #7202:
URL: https://github.com/apache/arrow/pull/7202#discussion_r426665679



##########
File path: cpp/src/arrow/array.h
##########
@@ -798,7 +798,12 @@ class ARROW_EXPORT FixedSizeListArray : public Array {
     i += data_->offset;
     return static_cast<int32_t>(list_size_ * i);
   }
+#ifdef _MSC_VER
   int32_t value_length(int64_t i = 0) const { return list_size_; }
+#else
+  int32_t value_length(__attribute__((unused)) int64_t i = 0) const { return list_size_; }

Review comment:
       I would be surprised if this were the only place where a parameter isn't used. Also, @kou is right that this should use a macro.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org