You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/14 09:43:57 UTC

[GitHub] [apisix] SkyeYoung commented on a diff in pull request #7235: docs: update Chinese opentelemetry docs

SkyeYoung commented on code in PR #7235:
URL: https://github.com/apache/apisix/pull/7235#discussion_r896608038


##########
docs/zh/latest/plugins/opentelemetry.md:
##########
@@ -136,7 +135,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1  -H 'X-API-KEY: edd1c9f034335
     "upstream": {
         "type": "roundrobin",
         "nodes": {
-            "10.110.149.175:8089": 1
+            "127.0.0.1:1980": 1

Review Comment:
   > ๐Ÿ˜‚ For me, as a web developer, I could understand `3000` port is an app port. `1980` is not easy to understand, people will think what's it used for?
   
   Well, I think itโ€™s ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org