You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/23 22:56:04 UTC
[GitHub] [airflow] omer-ginosar opened a new pull request #21052: Fixed instructions for custom image build with docker compose
omer-ginosar opened a new pull request #21052:
URL: https://github.com/apache/airflow/pull/21052
This is a fix to the "Building the image" article which skips an important step needed for adding the custom image to docker-compose.
The fix is following the discussion on this thread: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1641251963210900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21052: Improved instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21052:
URL: https://github.com/apache/airflow/pull/21052#issuecomment-1021632327
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21052: Improved instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21052:
URL: https://github.com/apache/airflow/pull/21052#issuecomment-1020969319
Needs some static checks/docs fixes - I am afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21052: Improved instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21052:
URL: https://github.com/apache/airflow/pull/21052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21052: Fixed instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21052:
URL: https://github.com/apache/airflow/pull/21052#discussion_r790344659
##########
File path: docs/docker-stack/build.rst
##########
@@ -81,7 +81,9 @@ In the simplest case building your image consists of those steps:
4) Once you build the image locally you have usually several options to make them available for your deployment:
-* For ``docker-compose`` deployment, that's all you need. The image is stored in Docker engine cache
+* For ``docker-compose`` deployment, open your ``docker-compose.yaml`` file and search for the phrase "In order
+ to add custom dependencies". Follow these instructions of commenting the "image" line and uncommenting the
+ "build" line. Then run `docker-compose build` to build the images. The image is stored in Docker engine cache
and Docker Compose will use it from there.
Review comment:
This would be a much more accurate description. There are several ways you can build an use image for docker-compose and they have pros and cons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21052: Improved instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21052:
URL: https://github.com/apache/airflow/pull/21052#issuecomment-1021642990
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21052: Improved instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21052:
URL: https://github.com/apache/airflow/pull/21052#issuecomment-1020969319
Needs some static checks/docs fixes - I am afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21052: Fixed instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21052:
URL: https://github.com/apache/airflow/pull/21052#issuecomment-1019584826
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21052: Fixed instructions for custom image build with docker compose
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21052:
URL: https://github.com/apache/airflow/pull/21052#discussion_r790344541
##########
File path: docs/docker-stack/build.rst
##########
@@ -81,7 +81,9 @@ In the simplest case building your image consists of those steps:
4) Once you build the image locally you have usually several options to make them available for your deployment:
-* For ``docker-compose`` deployment, that's all you need. The image is stored in Docker engine cache
+* For ``docker-compose`` deployment, open your ``docker-compose.yaml`` file and search for the phrase "In order
+ to add custom dependencies". Follow these instructions of commenting the "image" line and uncommenting the
+ "build" line. Then run `docker-compose build` to build the images. The image is stored in Docker engine cache
and Docker Compose will use it from there.
Review comment:
```suggestion
* For ``docker-compose`` deployment, if you've already built your image, and want to continue
building the image manually when needed with ``docker build``, you can edit the
docker-compose.yaml and replace the "apache/airflow:<version>" image with the
image you've just built ``my-image:0.0.1`` - it will be used from your local Docker
Engine cache. You can also simply set ``AIRFLOW_IMAGE_NAME`` variable to
point to your image and ``docer-compose` will use it automatically without having
to modify the file.
* Also for ``docker-compose`` deployment, you can delegate image building to the docker-compose.
To do that - open your ``docker-compose.yaml`` file and search for the phrase "In order
to add custom dependencies". Follow these instructions of commenting the "image"
line and uncommenting the "build" line. This is a standard docker-compose feature
and you can read about it in
`Docker Compose build reference <https://docs.docker.com/compose/reference/build/>`_.
Run `docker-compose build` to build the images. Simoilarly as in the previous case, the
image is stored in Docker engine cache and Docker Compose will use it from there.
The `docker-compose build` command uses the same `docker build` command that
you can run manually under-the-hood.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org