You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 06:42:28 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #27917: add some important log in aws athena hook

uranusjr commented on code in PR #27917:
URL: https://github.com/apache/airflow/pull/27917#discussion_r1036740606


##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -109,7 +113,11 @@ def check_query_status(self, query_execution_id: str) -> str | None:
         try:
             state = response["QueryExecution"]["Status"]["State"]
         except Exception as ex:
-            self.log.error("Exception while getting query state %s", ex)
+            self.log.error(
+                "Exception while getting query state %s. Query execution id: %s",
+                ex,
+                query_execution_id,
+            )

Review Comment:
   Do we want to use `log.exception` instead? (Same for other calls below)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org