You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/11/29 07:56:35 UTC

[GitHub] [gobblin] codecov-commenter commented on pull request #3611: Fix the type of default values to match what Schema.parse() does.

codecov-commenter commented on PR #3611:
URL: https://github.com/apache/gobblin/pull/3611#issuecomment-1330225559

   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3611?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3611](https://codecov.io/gh/apache/gobblin/pull/3611?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4240794) into [master](https://codecov.io/gh/apache/gobblin/commit/c6d6c1ba10357d4689c0d5ba1e29846e613deaaf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6d6c1b) will **decrease** coverage by `3.13%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3611      +/-   ##
   ============================================
   - Coverage     46.87%   43.74%   -3.14%     
   + Complexity    10687     2060    -8627     
   ============================================
     Files          2125      408    -1717     
     Lines         83157    17627   -65530     
     Branches       9266     2154    -7112     
   ============================================
   - Hits          38983     7711   -31272     
   + Misses        40598     9057   -31541     
   + Partials       3576      859    -2717     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `56.50% <100.00%> (ø)` | |
   | [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `62.36% <0.00%> (-2.16%)` | :arrow_down: |
   | [...ion/mapreduce/orc/OrcKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNLZXlDb21wYWN0b3JPdXRwdXRGb3JtYXQuamF2YQ==) | | |
   | [...ement/copy/TimeAwareCopyableGlobDatasetFinder.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvVGltZUF3YXJlQ29weWFibGVHbG9iRGF0YXNldEZpbmRlci5qYXZh) | | |
   | [...bblin/metrics/event/EntityMissingEventBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9FbnRpdHlNaXNzaW5nRXZlbnRCdWlsZGVyLmphdmE=) | | |
   | [...n/runtime/job\_exec/JobLauncherExecutionDriver.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2V4ZWMvSm9iTGF1bmNoZXJFeGVjdXRpb25Ecml2ZXIuamF2YQ==) | | |
   | [...n/yarn/event/GetApplicationReportFailureEvent.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vZXZlbnQvR2V0QXBwbGljYXRpb25SZXBvcnRGYWlsdXJlRXZlbnQuamF2YQ==) | | |
   | [...t/version/FileStatusTimestampedDatasetVersion.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vRmlsZVN0YXR1c1RpbWVzdGFtcGVkRGF0YXNldFZlcnNpb24uamF2YQ==) | | |
   | [...rg/apache/gobblin/source/jdbc/OracleExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL09yYWNsZUV4dHJhY3Rvci5qYXZh) | | |
   | [...in/instrumented/fork/InstrumentedForkOperator.java](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5zdHJ1bWVudGVkL2ZvcmsvSW5zdHJ1bWVudGVkRm9ya09wZXJhdG9yLmphdmE=) | | |
   | ... and [1710 more](https://codecov.io/gh/apache/gobblin/pull/3611/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org