You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "keon94 (via GitHub)" <gi...@apache.org> on 2023/05/04 21:26:33 UTC
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #4906: [feat-4762]: Support deleting data by scope
keon94 commented on code in PR #4906:
URL: https://github.com/apache/incubator-devlake/pull/4906#discussion_r1185534759
##########
backend/helpers/pluginhelper/api/api_collector.go:
##########
@@ -356,7 +356,7 @@ func (collector *ApiCollector) generateUrl(pager *Pager, input interface{}) (str
var buf bytes.Buffer
err := collector.urlTemplate.Execute(&buf, &RequestData{
Pager: pager,
- Params: collector.args.Params,
+ Params: collector.args.Options.GetParams(),
Review Comment:
The "API Params" of subtasks is now the responsibility of the plugin's options to provide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org