You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2020/01/08 05:04:08 UTC

Review Request 71964: RANGER-2687: NoClassDefFoundError when Ranger Knox plugin is enabled

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71964/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2687
    https://issues.apache.org/jira/browse/RANGER-2687


Repository: ranger


Description
-------

** Problem Statement: **

RANGER-2555 introduced  RangerRESTClient dependency on RangerAdminJersey2RESTClient. Which forces Java to pull in the RangerRESTClient from RangerAdminJersey2RESTClient. This causes the classes to try to be loaded even though its a static method for getURLs.

** Proposed solution: **

Moved function RangerRESTClient.getURLs() to StringUtil class which does not pulls in any other dependencies. RangerAdminRESTClient and RangerAdminJersey2RESTClient can refer to it.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java 17a0651f3 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 0f44a5dbe 
  knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java 8ac62d3df 


Diff: https://reviews.apache.org/r/71964/diff/1/


Testing
-------

Replaced the jar with the patch and error is not appearing now.


Thanks,

Pradeep Agrawal


Re: Review Request 71964: RANGER-2687: NoClassDefFoundError when Ranger Knox plugin is enabled

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71964/#review219170
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Jan. 8, 2020, 5:04 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71964/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2020, 5:04 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2687
>     https://issues.apache.org/jira/browse/RANGER-2687
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** Problem Statement: **
> 
> RANGER-2555 introduced  RangerRESTClient dependency on RangerAdminJersey2RESTClient. Which forces Java to pull in the RangerRESTClient from RangerAdminJersey2RESTClient. This causes the classes to try to be loaded even though its a static method for getURLs.
> 
> ** Proposed solution: **
> 
> Moved function RangerRESTClient.getURLs() to StringUtil class which does not pulls in any other dependencies. RangerAdminRESTClient and RangerAdminJersey2RESTClient can refer to it.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java 17a0651f3 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 0f44a5dbe 
>   knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java 8ac62d3df 
> 
> 
> Diff: https://reviews.apache.org/r/71964/diff/1/
> 
> 
> Testing
> -------
> 
> Replaced the jar with the patch and error is not appearing now.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>