You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/17 13:50:42 UTC
[GitHub] [trafficcontrol] jrushford opened a new pull request #6667: Restores logging the cache status.
jrushford opened a new pull request #6667:
URL: https://github.com/apache/trafficcontrol/pull/6667
When the tc-health-client was switched to using the combined
TM CrStates endpoint, the ability to log the cache status was
lost, Issue #6448. PR #6612 adds the cache status field to the
TM CrStates endpoint allowing cache status to be logged again.
This PR adds back the cache status logging.
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #6448
Related: #6612
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Control Health Client (tc-health-client)
- Traffic Control Client <!-- Please specify which (Python, Go, or Java) -->
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
run unit and integration tests.
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6667: Restores logging the cache status.
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #6667:
URL: https://github.com/apache/trafficcontrol/pull/6667#issuecomment-1071428544
The license tests failed because
> GitHub Actions has encountered an internal error when running your job.
I haven't looked at the other yet, but I'm sure it's the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #6667: Restores logging the cache status.
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #6667:
URL: https://github.com/apache/trafficcontrol/pull/6667#issuecomment-1071428544
The license tests failed because
> GitHub Actions has encountered an internal error when running your job.
I haven't looked at the other yet, but I'm sure it's the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on pull request #6667: Restores logging the cache status.
Posted by GitBox <gi...@apache.org>.
jrushford commented on pull request #6667:
URL: https://github.com/apache/trafficcontrol/pull/6667#issuecomment-1071168933
@ocket8888 I'm unable to see any logs for the failing tests. I can't imagine why the Weasel license checks failed. CI issue? Could you restart the CI tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #6667: Restores logging the cache status.
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #6667:
URL: https://github.com/apache/trafficcontrol/pull/6667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on pull request #6667: Restores logging the cache status.
Posted by GitBox <gi...@apache.org>.
jrushford commented on pull request #6667:
URL: https://github.com/apache/trafficcontrol/pull/6667#issuecomment-1071168933
@ocket8888 I'm unable to see any logs for the failing tests. I can't imagine why the Weasel license checks failed. CI issue? Could you restart the CI tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org