You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/22 02:04:21 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #16994: Use SPI module in SQL parser module
terrymanu opened a new issue, #16994:
URL: https://github.com/apache/shardingsphere/issues/16994
The current SQL parser module use SPI, but do not depend SPI module.
There are duplicated codes on SPI logic.
I want to discuss let SQL parser module depend SPI module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #16994: Use SPI module in SQL parser module
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #16994: Use SPI module in SQL parser module
URL: https://github.com/apache/shardingsphere/issues/16994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on issue #16994: Use SPI module in SQL parser module
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on issue #16994:
URL: https://github.com/apache/shardingsphere/issues/16994#issuecomment-1106003400
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #16994: Use SPI module in SQL parser module
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #16994:
URL: https://github.com/apache/shardingsphere/issues/16994#issuecomment-1122535364
Fixed by #17527 and #17528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #16994: Use SPI module in SQL parser module
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #16994:
URL: https://github.com/apache/shardingsphere/issues/16994#issuecomment-1105973457
That's great, the unified SPI usage is much more readable and maintainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #16994: Use SPI module in SQL parser module
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #16994:
URL: https://github.com/apache/shardingsphere/issues/16994#issuecomment-1105968822
Great idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org