[jira] Closed: (OFBIZ-3430) The positioning mechanism of the new lookups is only working with the bizznesstime theme

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3430.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Sascha,

Your (slightly modified) patch is in trunk at r906524. 

For the moment I only removed comments around an error which is useful. I guess it blocked you during your tests and your forgot to remove it. BTW I improved the error and one related (variables names explicit)

I will certainly do a review on the format later to avoid both in the same commit (if any changes are needed anyway).

I will soon speak about that on dev ML and we will see how the community think about it. Should not be too hard to convince people now



> The positioning mechanism of the new lookups is only working with the bizznesstime theme 
> -----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3430
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3430
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>         Environment: XP / FF3.6
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3430_lookup_extend.patch, OFBIZ-3430_lookup_extend.patch
>
>
> I find that the positioning mechanism is only working with the bizznesstime theme (at list centering, the only case I tried with all themes). But it should not be a big deal to fix since it works already in one theme.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.