You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/03/08 18:47:48 UTC
[kudu-CR] [gutil] fix build on macOS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12703
Change subject: [gutil] fix build on macOS
......................................................................
[gutil] fix build on macOS
The newly-added sysinfo-test consists of scenarios for Linux-specific
ParseMaxCpuIndex() function. This function is not implemented on macOS,
so the sysinfo-test in its current state makes sense only for Linux
Kudu builds.
This is a follow-up to feebbb2649a659bbd6b2fdcfc6a347eafbccba2b.
Change-Id: I3c954b66534690b2c50e86d15f9c9be9d4ce3ed7
---
M src/kudu/gutil/CMakeLists.txt
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/12703/1
--
To view, visit http://gerrit.cloudera.org:8080/12703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c954b66534690b2c50e86d15f9c9be9d4ce3ed7
Gerrit-Change-Number: 12703
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [gutil] fix build on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12703 )
Change subject: [gutil] fix build on macOS
......................................................................
[gutil] fix build on macOS
The newly-added sysinfo-test consists of scenarios for Linux-specific
ParseMaxCpuIndex() function. This function is not implemented on macOS,
so the sysinfo-test in its current state makes sense only for Linux
Kudu builds.
This is a follow-up to feebbb2649a659bbd6b2fdcfc6a347eafbccba2b.
Change-Id: I3c954b66534690b2c50e86d15f9c9be9d4ce3ed7
Reviewed-on: http://gerrit.cloudera.org:8080/12703
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/gutil/CMakeLists.txt
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c954b66534690b2c50e86d15f9c9be9d4ce3ed7
Gerrit-Change-Number: 12703
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [gutil] fix build on macOS
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12703 )
Change subject: [gutil] fix build on macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c954b66534690b2c50e86d15f9c9be9d4ce3ed7
Gerrit-Change-Number: 12703
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 08 Mar 2019 18:53:08 +0000
Gerrit-HasComments: No