You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Germandrummer92 (via GitHub)" <gi...@apache.org> on 2023/01/25 12:10:52 UTC

[GitHub] [superset] Germandrummer92 commented on a diff in pull request #22744: fix(dependency): update cryptography import

Germandrummer92 commented on code in PR #22744:
URL: https://github.com/apache/superset/pull/22744#discussion_r1086560242


##########
superset/utils/core.py:
##########
@@ -1550,7 +1550,7 @@ def override_user(user: Optional[User], force: bool = True) -> Iterator[Any]:
         delattr(g, "user")
 
 
-def parse_ssl_cert(certificate: str) -> _Certificate:
+def parse_ssl_cert(certificate: str) -> Certificate:

Review Comment:
   good point, changed to the direct import of `load_pem_x509_certificate`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org